feat(provider/kubernetes): namespace deployManifest #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds fields for namespaceOverride to allow users to define the namespace their manifests are deployed into (particularly for manifests baked from Helm charts).
ethanfrogers
force-pushed
the
deploy-manifest-namespace
branch
from
f48c5f5
to
d7c5d0f
Compare
maggieneterval
approved these changes
May 16, 2019
| @@ -19,7 +19,7 @@ export function ManifestBasicSettings({ | |||
| selectedAccount, | |||
| }: IManifestBasicSettingsProps) { | |||
| return ( | |||
| <div className="container-fluid form-horizontal"> | |||
There was a problem hiding this comment.
was this class just not doing anything?
There was a problem hiding this comment.
It was causing some alignment issues if things were added underneath it in other forms.
maggieneterval
added a commit
to maggieneterval/deck
that referenced
this pull request
Jun 3, 2019
89e4e78 fix(runJob/kubernetes): reliably display logs (spinnaker#7060) f0287a1 fix(runJob/kubernetes): use explicit pod name (spinnaker#7039) 3fd183e fix(kubernetes): fix runjob stage init (spinnaker#7029) 4f4c32b feat(provider/kubernetes): namespace deployManifest (spinnaker#7016) 8e97d59 refactor(kubernetes): namespace selector component (spinnaker#7012) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (spinnaker#7002) 0194821 feat(runjob): capture output ui (spinnaker#6978)
maggieneterval
added a commit
that referenced
this pull request
Jun 3, 2019
89e4e78 fix(runJob/kubernetes): reliably display logs (#7060) f0287a1 fix(runJob/kubernetes): use explicit pod name (#7039) 3fd183e fix(kubernetes): fix runjob stage init (#7029) 4f4c32b feat(provider/kubernetes): namespace deployManifest (#7016) 8e97d59 refactor(kubernetes): namespace selector component (#7012) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (#7002) 0194821 feat(runjob): capture output ui (#6978)
Mahito
added a commit
to Mahito/spinnaker
that referenced
this pull request
Oct 25, 2019
Adds fields for namespaceOverride to deployManifest. Ref. feat(provider/kubernetes): namespace deployManifest spinnaker/deck#7016
Mahito
added a commit
to Mahito/spinnaker
that referenced
this pull request
Nov 12, 2019
Adds fields for namespaceOverride to deployManifest. Ref. feat(provider/kubernetes): namespace deployManifest spinnaker/deck#7016
louisjimenez
pushed a commit
to spinnaker/spinnaker
that referenced
this pull request
Nov 12, 2019
) Adds fields for namespaceOverride to deployManifest. Ref. feat(provider/kubernetes): namespace deployManifest spinnaker/deck#7016
ttomsu
pushed a commit
to ttomsu/sponnet
that referenced
this pull request
Feb 5, 2020
…065) Adds fields for namespaceOverride to deployManifest. Ref. feat(provider/kubernetes): namespace deployManifest spinnaker/deck#7016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds fields for namespaceOverride to allow users to define the namespace
their manifests are deployed into (particularly for manifests baked from
Helm charts).
Default - no override
Namespace override enabled
Override enabled w/ SpEL expression