fix(kubernetes): fix runjob stage init #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix stage initialization by setting the stage's application config if it doesn't exist. this field is required to be set for the stage to work. initially i had assumed the that BasicSettings component would configure it.
maggieneterval
approved these changes
May 20, 2019
|
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
May 20, 2019
fix stage initialization by setting the stage's application config if it doesn't exist. this field is required to be set for the stage to work. initially i had assumed the that BasicSettings component would configure it.
|
Cherry pick successful: #7031 |
maggieneterval
pushed a commit
that referenced
this pull request
May 22, 2019
maggieneterval
added a commit
to maggieneterval/deck
that referenced
this pull request
Jun 3, 2019
89e4e78 fix(runJob/kubernetes): reliably display logs (spinnaker#7060) f0287a1 fix(runJob/kubernetes): use explicit pod name (spinnaker#7039) 3fd183e fix(kubernetes): fix runjob stage init (spinnaker#7029) 4f4c32b feat(provider/kubernetes): namespace deployManifest (spinnaker#7016) 8e97d59 refactor(kubernetes): namespace selector component (spinnaker#7012) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (spinnaker#7002) 0194821 feat(runjob): capture output ui (spinnaker#6978)
maggieneterval
added a commit
that referenced
this pull request
Jun 3, 2019
89e4e78 fix(runJob/kubernetes): reliably display logs (#7060) f0287a1 fix(runJob/kubernetes): use explicit pod name (#7039) 3fd183e fix(kubernetes): fix runjob stage init (#7029) 4f4c32b feat(provider/kubernetes): namespace deployManifest (#7016) 8e97d59 refactor(kubernetes): namespace selector component (#7012) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (#7002) 0194821 feat(runjob): capture output ui (#6978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix stage initialization by setting the stage's application config if it
doesn't exist. this field is required to be set for the stage to work.
initially i had assumed the that BasicSettings component would configure
it.