fix(artifacts/helm): support regex/spel in version #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only handles most of the cases where this can be set. I'm not sure what to do about |
app/scripts/modules/core/src/pipeline/config/triggers/artifacts/helm/HelmArtifactEditor.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/artifacts/helm/HelmArtifactEditor.tsx
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/artifacts/helm/HelmArtifactEditor.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/artifacts/helm/HelmArtifactEditor.tsx
Outdated
Show resolved
Hide resolved
maggieneterval
approved these changes
May 21, 2019
My suggestion would be converting it to React 👼 |
ethanfrogers
force-pushed
the
helm-artifact-regex
branch
from
c50c260
to
247b6f0
Compare
the version field in an artifact supports regex but the previous UI forced a hardcoded version. this made triggers really confusing because users are forced to set a version on the artifact when they really wanted something like `.*` to indicate that this chart should be matched for all versions.
ethanfrogers
force-pushed
the
helm-artifact-regex
branch
from
247b6f0
to
df76fe5
Compare
|
@maggieneterval Feedback addressed! Unfortunately, refactoring that bit to React is more work than I have time for at the moment. At least from what I can tell. I'll revisit again, later. |
anotherchrisberry
added a commit
that referenced
this pull request
May 28, 2019
…#7066) * chore(core): Bump version to 0.0.373 89e4e78 fix(runJob/kubernetes): reliably display logs (#7060) 50f23fc refactor(core): allow checklist component to accept objects as a prop (#7058) 0eaae9a refactor(core): expose clusterService in react injector (#7043) 8dd1417 fix(core): Build triggers: Properly render large number of jobs (#7056) 4975233 fix(artifacts/helm): support regex/spel in version (#7033) * chore(docker): Bump version to 0.0.41 59259a9 fix(docker): Fixed imageId parsing and digest support (#7053) * chore(titus): Bump version to 0.0.98 50f23fc refactor(core): allow checklist component to accept objects as a prop (#7058) 59259a9 fix(docker): Fixed imageId parsing and digest support (#7053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version field in an artifact supports regex but the previous UI
forced a hardcoded version. this made triggers really confusing because
users are forced to set a version on the artifact when they really
wanted something like
.*to indicate that this chart should be matchedfor all versions.