refactor(core): allow checklist component to accept objects as a prop #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently looking to refactor Notifications into React. |
|
LGTM |
anotherchrisberry
approved these changes
May 23, 2019
|
nice 👍 |
anotherchrisberry
added a commit
that referenced
this pull request
May 28, 2019
…#7066) * chore(core): Bump version to 0.0.373 89e4e78 fix(runJob/kubernetes): reliably display logs (#7060) 50f23fc refactor(core): allow checklist component to accept objects as a prop (#7058) 0eaae9a refactor(core): expose clusterService in react injector (#7043) 8dd1417 fix(core): Build triggers: Properly render large number of jobs (#7056) 4975233 fix(artifacts/helm): support regex/spel in version (#7033) * chore(docker): Bump version to 0.0.41 59259a9 fix(docker): Fixed imageId parsing and digest support (#7053) * chore(titus): Bump version to 0.0.98 50f23fc refactor(core): allow checklist component to accept objects as a prop (#7058) 59259a9 fix(docker): Fixed imageId parsing and digest support (#7053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checklist component more flexible by allowing the user to be able to specify a list of strings or a list of objects, similar to react-select