-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pipeline): Pipeline stage execution details to react #7063
refactor(pipeline): Pipeline stage execution details to react #7063
Conversation
}} | ||
options={{ inherit: false, reload: 'home.applications.application.pipelines.executionDetails' }} | ||
> | ||
<a target="_self">View Pipeline Execution</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does target="_self"
do that omitting target
would not do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It opts out of angular's rewriteLinks, which #7064 will do globally. Without it, there was an issue with the reload
option not being respected I think due to the order of event handling.
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (spinnaker#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (spinnaker#7064) 3f21c1f feat(executions): Adding redirect for execution without application (spinnaker#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (spinnaker#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (spinnaker#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (spinnaker#7078) b142789 fix(triggers): Poll on execution id instead of event id (spinnaker#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (spinnaker#7063)
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (#7064) 3f21c1f feat(executions): Adding redirect for execution without application (#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (#7078) b142789 fix(triggers): Poll on execution id instead of event id (#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (#7063)
No description provided.