fix(core): Disable rewriteLinks to allow proper event handling #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Jun 4, 2019
|
here is the AngularJS click handler: https://github.com/angular/angular.js/blob/864c7f0/src/ng/location.js#L894-L937 |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (spinnaker#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (spinnaker#7064) 3f21c1f feat(executions): Adding redirect for execution without application (spinnaker#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (spinnaker#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (spinnaker#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (spinnaker#7078) b142789 fix(triggers): Poll on execution id instead of event id (spinnaker#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (spinnaker#7063)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (#7064) 3f21c1f feat(executions): Adding redirect for execution without application (#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (#7078) b142789 fix(triggers): Poll on execution id instead of event id (#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (#7063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, in certain scenarios Angular ends up preventing react from being able to properly handle the link's
clickevent, causing some unexpected behavior.This should cause any issues, but if it does, we should try to fix those issues if we can instead of simply reverting this change.