Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider/azure): Enable data disk for server group #7116

Merged
merged 4 commits into from
Jun 14, 2019
Merged

feat(provider/azure): Enable data disk for server group #7116

merged 4 commits into from
Jun 14, 2019

Conversation

neil-yechenwei
Copy link

@neil-yechenwei neil-yechenwei commented Jun 14, 2019

Background:
Add a new feature to mount data disk to server group. Please also help to review the related clouddriver PR(spinnaker/clouddriver#3788).

Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@maggieneterval maggieneterval merged commit f650ca9 into spinnaker:master Jun 14, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Aug 8, 2019
abac63c feat(*/pipeline): Remove the concept of default stage timeouts, rename option (spinnaker#7286)
cdd6f23 chore(package): Just Update Prettier™
f650ca9 feat(provider/azure): Enable data disk for server group (spinnaker#7116)
caseyhebebrand added a commit to caseyhebebrand/deck that referenced this pull request Oct 16, 2019
abac63c feat(*/pipeline): Remove the concept of default stage timeouts, rename option (spinnaker#7286)
cdd6f23 chore(package): Just Update Prettier™
f650ca9 feat(provider/azure): Enable data disk for server group (spinnaker#7116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants