fix(ecs) add missing context images when building new server group cm… #7123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
allisaurus
force-pushed
the
ecs-contextimage-fix
branch
from
36369f4
to
8bb409a
Compare
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 3, 2019
ea730f4 fix(ecs): Disable artifact selection outside of pipelines (spinnaker#7170) 58b9867 fix(ecs): Set viewState.mode when creating server group for pipeline (spinnaker#7169) 5401a87 feat(esc): Add support for task definition artifacts (spinnaker#7162) 1532db4 fix(ecs): add missing context images when building new server group for pipeline (spinnaker#7123) cdd6f23 chore(package): Just Update Prettier™
christopherthielen
added a commit
that referenced
this pull request
Jul 3, 2019
ea730f4 fix(ecs): Disable artifact selection outside of pipelines (#7170) 58b9867 fix(ecs): Set viewState.mode when creating server group for pipeline (#7169) 5401a87 feat(esc): Add support for task definition artifacts (#7162) 1532db4 fix(ecs): add missing context images when building new server group for pipeline (#7123) cdd6f23 chore(package): Just Update Prettier™
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, in the "deploy" stage, if you have an image trigger configured on your pipeline, it will be available in the "Container Image" drop-down when editing an existing server group:
However, if you try to create a new server group within the same stage, the trigger image will be missing:
explanation
This is b/c "buildNewServerGroupCommandForPipeline" needs to set the context images on
viewState.overrides.viewStateso that they are retained after template selection.solution
After this change, the trigger image now appears when creating a new server group for the deploy stage:
