fix(ecs): Disable artifact selection outside of pipelines #7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareliguori
approved these changes
Jul 1, 2019
anotherchrisberry
suggested changes
Jul 2, 2019
| id="taskDefinitionSourceArtifact" | ||
| /> | ||
| Artifact | ||
| </label> | ||
| </div> | ||
| </div> | ||
| <div ng-if="command.viewState.mode == 'create'" style="color:#666;"> |
There was a problem hiding this comment.
Suggested change
| <div ng-if="command.viewState.mode == 'create'" style="color:#666;"> | |
| <div ng-if="command.viewState.mode === 'create'" class="color-text-caption"> |
The === is super minor; the color selection via CSS class is based off the style guide (accessible when running locally via http://localhost:9000/#/styleguide#psg-link-0).
There was a problem hiding this comment.
Makes perfect sense! Will update.
| @@ -24,12 +24,17 @@ | |||
| type="radio" | |||
| ng-model="command.useTaskDefinitionArtifact" | |||
| ng-value="true" | |||
| ng-disabled="command.viewState.mode == 'create'" | |||
There was a problem hiding this comment.
Suggested change
| ng-disabled="command.viewState.mode == 'create'" | |
| ng-disabled="command.viewState.mode === 'create'" |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 3, 2019
ea730f4 fix(ecs): Disable artifact selection outside of pipelines (spinnaker#7170) 58b9867 fix(ecs): Set viewState.mode when creating server group for pipeline (spinnaker#7169) 5401a87 feat(esc): Add support for task definition artifacts (spinnaker#7162) 1532db4 fix(ecs): add missing context images when building new server group for pipeline (spinnaker#7123) cdd6f23 chore(package): Just Update Prettier™
christopherthielen
added a commit
that referenced
this pull request
Jul 3, 2019
ea730f4 fix(ecs): Disable artifact selection outside of pipelines (#7170) 58b9867 fix(ecs): Set viewState.mode when creating server group for pipeline (#7169) 5401a87 feat(esc): Add support for task definition artifacts (#7162) 1532db4 fix(ecs): add missing context images when building new server group for pipeline (#7123) cdd6f23 chore(package): Just Update Prettier™
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables artifact selection when creating an ECS server group outside of a pipeline (since pipeline "expected artifacts" are needed for them to work).
New UI msg