fix(core): filter falsy error messages from errors object on tasks #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but you know i don't speak JS :) |
Yeah, that is why I tagged you on the PR, I just wanted an easy thumbs up, not a real review |
anotherchrisberry
added a commit
that referenced
this pull request
Jun 26, 2019
…94 (#7150) * chore(core): Bump version to 0.0.377 d5425b4 refactor(core): virtualize execution rendering (#7140) 342087c feat(core): allow users to override pipeline graph positions (#7141) fb58d70 fix(core): do not send a cloud provider on v2 search calls (#7142) 5d6d9aa chore(core): clarify clone stage help text (#7131) 745f0a1 fix(core): Display latest template in pipeline template list (#7145) 456172b fix(webhooks): addresses issue 3450 - introduce a delay before polling webhook (#7144) 7238d1d feat(core): Enable new artifacts workflow in bakeManifest (#7138) 45e5aa3 feat(artifacts): find multiple artifacts from single execution (#7139) dae73da fix(core): provide key for repeating param JSX elements (#7136) bbc1d06 fix(core): filter falsy error messages from errors object on tasks (#7135) 4782808 refactor(core): Reactify overrideTimeout (#7126) 0a3bd68 feat(core/presentation): Always call onBlur in Checklist to "mark as touched" (#7134) cdd6f23 chore(package): Just Update Prettier™ 7e464a9 fix(amazon): Support SpEL in advanced capacity (#7124) 08e9506 chore(deck): Update to Typescript 3.4 fa515dc fix(core): do not stretch provider logos in selection modal (#7128) * chore(docker): Bump version to 0.0.42 8358010 fix(docker): Allow auto-switch to manual entry when refreshing images (#7120) * chore(amazon): Bump version to 0.0.194 cdd6f23 chore(package): Just Update Prettier™ 7e464a9 fix(amazon): Support SpEL in advanced capacity (#7124) 08e9506 chore(deck): Update to Typescript 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worth digging into the backend, but we ran into an internal error that resulted in
"errors": [null], so we should filter those out and surface the"error"field, if it's present.