Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): find multiple artifacts from single execution #7139

Merged
merged 2 commits into from Jun 21, 2019

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Jun 21, 2019

Closes spinnaker/spinnaker#4354
Orca PR: spinnaker/orca#3006

  • Enables the selection of multiple artifacts in the Find Artifact from Execution stage.
  • Makes minor UI changes to Find Artifact execution details tab.

Before:
before

After:
after

@maggieneterval
Copy link
Contributor Author

Actually I'm also very open to just deleting the first execution details tab, since there's also the Artifact Status tab and if you need to see the JSON you can always open the full execution source 🤷‍♀️

Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm ambivalent about whether to delete the first stage or not---it might be slightly more convenient to have it there rather than in the pipeline json 🤷‍♂️

@maggieneterval
Copy link
Contributor Author

Okay I'll leave it in for now! Curious for @thecodejunkie's thoughts on the UI!

@maggieneterval maggieneterval merged commit 45e5aa3 into spinnaker:master Jun 21, 2019
@maggieneterval maggieneterval deleted the find-mult-artifacts branch June 21, 2019 22:18
anotherchrisberry added a commit that referenced this pull request Jun 26, 2019
…94 (#7150)

* chore(core): Bump version to 0.0.377

d5425b4 refactor(core): virtualize execution rendering (#7140)
342087c feat(core): allow users to override pipeline graph positions (#7141)
fb58d70 fix(core): do not send a cloud provider on v2 search calls (#7142)
5d6d9aa chore(core): clarify clone stage help text (#7131)
745f0a1 fix(core): Display latest template in pipeline template list (#7145)
456172b fix(webhooks): addresses issue 3450 - introduce a delay before polling webhook (#7144)
7238d1d feat(core): Enable new artifacts workflow in bakeManifest (#7138)
45e5aa3 feat(artifacts): find multiple artifacts from single execution (#7139)
dae73da fix(core): provide key for repeating param JSX elements (#7136)
bbc1d06 fix(core): filter falsy error messages from errors object on tasks (#7135)
4782808 refactor(core): Reactify overrideTimeout (#7126)
0a3bd68 feat(core/presentation): Always call onBlur in Checklist to "mark as touched" (#7134)
cdd6f23 chore(package): Just Update Prettier™
7e464a9 fix(amazon): Support SpEL in advanced capacity (#7124)
08e9506 chore(deck): Update to Typescript 3.4
fa515dc fix(core): do not stretch provider logos in selection modal (#7128)

* chore(docker): Bump version to 0.0.42

8358010 fix(docker): Allow auto-switch to manual entry when refreshing images (#7120)

* chore(amazon): Bump version to 0.0.194

cdd6f23 chore(package): Just Update Prettier™
7e464a9 fix(amazon): Support SpEL in advanced capacity (#7124)
08e9506 chore(deck): Update to Typescript 3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants