fix(provider/openstack): Properly set the attributes of a strtegy pipeline

[randomswdev]

The openstack clouddriver in Deck does not properly set the ID of a strategy pipeline when used as a custom step in a deploy pipeline.

This makes Orca fail the lookup of the strategy pipeline when executing the deployment. The pull request is aimed at properly setting the required attributes.

[anotherchrisberry]

LGTM - @maggieneterval should this go into master and be cherry picked into the release branch?

[maggieneterval]

@anotherchrisberry Sure thing, I can take care of that!

[maggieneterval]

@spinnakerbot cherry-pick 1.14

[spinnakerbot]

Cherry pick failed: Command failed (cherry pick commit f50e952) with exit code 1:

error: could not apply f50e95274... fix(provider/openstack): Properly set the attributes of a strtegy pipeline (#7137)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

[maggieneterval]

Whoops my bad, I didn't realize this PR was against the 1.13 release branch and not master -- @randomswdev, is there a reason that we only need this commit for 1.13? Generally our pattern is to merge commits into the master branch, and then cherry-pick the commits back to prior releases as needed. If this is a fix that applies to master and 1.14 as well, would you mind opening another PR against master? Then we can merge that, and cherry-pick back to 1.14 as well. Otherwise, if this fix does for some reason only apply to 1.13, just let me know! Thanks! 😄

[randomswdev]

My understanding is that openstack has been removed from spinnaker versions > 1.13 (so the openstack code is no longer present or is planned to be removed).. For this reason I'm targeting this to 1.13.
There are some discussions in our team about offering our help for supporting/maintaining the openstack driver in newer releases of spinnaker. If we decide to move forward with this proposal, we will open an issue and decide with the community if/how to restore the openstack code in newer releases.

[anotherchrisberry]

Oh, right, that makes sense @randomswdev - sorry for the confusion!

[maggieneterval]

Thanks @randomswdev, and yes, sorry for the confusion!