Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/task): UserVerification: Accept an 'account' prop. #7173

Merged
merged 2 commits into from
Jul 1, 2019
Merged

feat(core/task): UserVerification: Accept an 'account' prop. #7173

merged 2 commits into from
Jul 1, 2019

Conversation

christopherthielen
Copy link
Contributor

  • auto-hide when the account doesn't "challengeDestructiveActions"
  • migrate to hooks

christopherthielen and others added 2 commits July 1, 2019 15:54
@christopherthielen
feat(core/task): UserVerification: Accept an 'account' prop.
3f67fb8 
- auto-hide when the account doesn't "challengeDestructiveActions"
- use hooks
@christopherthielen
Merge branch 'master' into user-verification
884a6f0
@christopherthielen
Copy link
Contributor Author

Screen Shot 2019-07-01 at 4 19 32 PM

  • Always visible when using expectedValue

    <UserVerification expectedValue="typethismessageexactly" onValidChange={valid => setValid(valid)} />

  • Visible because prod account has challengeDestructiveActions flag

    <UserVerification account="prod" onValidChange={valid => setValid(valid)} />

  • Hidden because test account does not have challengeDestructiveActions flag

    <UserVerification account="test" onValidChange={valid => setValid(valid)} />

anotherchrisberry
anotherchrisberry approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@anotherchrisberry anotherchrisberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@christopherthielen christopherthielen merged commit 40eb939 into spinnaker:master Jul 1, 2019
@christopherthielen christopherthielen deleted the user-verification branch July 1, 2019 23:52
alanmquach added a commit to alanmquach/deck that referenced this pull request Jul 3, 2019
@alanmquach
chore(core): Bump version to 0.0.382
550203b 
51b8d2d feat(trigger): Allow entry of explicit build number (spinnaker#7176)
9eb04b4 fix(pipeline): Fixed stage config for faileventual (spinnaker#7174)
40eb939 feat(core/task): UserVerification: Accept an 'account' prop. (spinnaker#7173)
97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (spinnaker#7171)
@alanmquach alanmquach mentioned this pull request Jul 3, 2019
Merged
alanmquach added a commit that referenced this pull request Jul 3, 2019
@alanmquach
Bump package core to 0.0.382 and amazon to 0.0.199 (#7179)
4d9a192 
* chore(core): Bump version to 0.0.382

51b8d2d feat(trigger): Allow entry of explicit build number (#7176)
9eb04b4 fix(pipeline): Fixed stage config for faileventual (#7174)
40eb939 feat(core/task): UserVerification: Accept an 'account' prop. (#7173)
97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (#7171)

* chore(amazon): Bump version to 0.0.199

97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (#7171)
saimadineni pushed a commit to saimadineni/deck that referenced this pull request Sep 24, 2019
@christopherthielen
# This is a combination of 6 commits.
1584426 
# This is the 1st commit message:

feat(core/task): UserVerification: Accept an 'account' prop. (spinnaker#7173)

- auto-hide when the account doesn't "challengeDestructiveActions"
- use hooks
# This is the commit message #2:

Added functions route and init  folder

# This is the commit message #3:

Added missing IFunction dependency

# This is the commit message #4:

Cleanup any loadbalancer ref

# This is the commit message #5:

Removed extra imports

# This is the commit message #6:

More cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anotherchrisberry anotherchrisberry anotherchrisberry approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
3 participants
@christopherthielen @anotherchrisberry @spinnakerbot