Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trigger): Allow entry of explicit build number #7176

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

alanmquach
Copy link
Contributor

If for some reason the build you're after is not found or not in the list.

aquachpy_·_Pipeline_Executions

aquachpy_·_Pipeline_Executions

@anotherchrisberry
Copy link
Contributor

What's the scenario where Igor can't find a build to display here but doesn't blow up when we trigger a pipeline referencing that same build?

How would you feel about using a custom menuRenderer (we do something similar-ish in the <AmazonImageSelectInput>) and putting the link to select a build manually as either
a) the last item in the list of builds, or
b) in a custom footer (always visible) on the menu when it's opened

@alanmquach
Copy link
Contributor Author

The Jenkins API only returns the most recent 100. If someone needs to trigger a pipeline against an older build that still exists in Jenkins, there's no way to do it from deck.

Cool, I didn't know about custom menuRenderers. Let me take a look at making it a sticky footer.

@alanmquach
Copy link
Contributor Author

Oh, but that wouldn't work for the error or none cases.

@anotherchrisberry
Copy link
Contributor

Then I approve

</div>
)}
{builds.length > 0 && (
<div className="col-md-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this reads surprisingly nice. I like!

@alanmquach alanmquach merged commit 51b8d2d into spinnaker:master Jul 2, 2019
alanmquach added a commit to alanmquach/deck that referenced this pull request Jul 3, 2019
51b8d2d feat(trigger): Allow entry of explicit build number (spinnaker#7176)
9eb04b4 fix(pipeline): Fixed stage config for faileventual (spinnaker#7174)
40eb939 feat(core/task): UserVerification: Accept an 'account' prop. (spinnaker#7173)
97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (spinnaker#7171)
alanmquach added a commit that referenced this pull request Jul 3, 2019
* chore(core): Bump version to 0.0.382

51b8d2d feat(trigger): Allow entry of explicit build number (#7176)
9eb04b4 fix(pipeline): Fixed stage config for faileventual (#7174)
40eb939 feat(core/task): UserVerification: Accept an 'account' prop. (#7173)
97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (#7171)

* chore(amazon): Bump version to 0.0.199

97c4aed refactor(core/serverGroup): Extract MinMaxDesiredChanges component (#7171)
@alanmquach alanmquach deleted the manual-branch-number branch July 10, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants