fix(core): fix flickering render of stage labels on hydration #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,6 +165,7 @@ export class HoverablePopover extends React.Component<IHoverablePopoverProps, IH | |||
| placement={placementOverride || placement} | |||
| target={this.targetRef.current} | |||
| container={container} | |||
| shouldUpdatePosition={true} | |||
There was a problem hiding this comment.
Adding this because we're actually changing the children in the popover (instead of creating an entirely new one), which means we need to recompute its position when children change.
I only 30% understand why this works.
| @@ -43,17 +39,7 @@ export class ExecutionMarker extends React.Component<IExecutionMarkerProps, IExe | |||
| }; | |||
| } | |||
|
|
|||
| private hydrate = (): void => { | |||
There was a problem hiding this comment.
moving this hydration down to the label itself (which already had some redundant hydration code)
| @@ -12,7 +12,6 @@ Registry.pipeline.registerStage({ | |||
| }, | |||
| component: ConcourseStageConfig, | |||
| executionDetailsSections: [ConcourseExecutionDetails], | |||
| useCustomTooltip: true, | |||
There was a problem hiding this comment.
no it doesn't
| template = getExecutionWindowTemplate(); | ||
| } else if (suspendedStageTypes.has('waitForCondition')) { | ||
| template = getWaitForConditionTemplate(); | ||
| } |
There was a problem hiding this comment.
I hate an else if, but in this case, I think it's fairly clean to read?
This render method was pretty spaghetti'd before and I feel like this refactor makes it a lot easier to grok but I'm biased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You know the annoying thing where you hover over a stage and you get a loading indicator in a tooltip, and then it just goes away, and you have to mouse out and then back over the stage to see the label? This fixes that.