fix(executions): Clarify why executions are NOT_STARTED #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmquach
requested review from
anotherchrisberry,
christopherthielen and
emjburns
|
I ❤️ it. Travis 🙅♀️ doesn't. |
alanmquach
force-pushed
the
explain-not-started
branch
from
bb10575
to
551023a
Compare
|
If it were in parentheses I would love it |
anotherchrisberry
suggested changes
Jul 3, 2019
app/scripts/modules/core/src/pipeline/executions/execution/Execution.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/executions/execution/Execution.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Chris Berry <chrisb@netflix.com>
Co-Authored-By: Chris Berry <chrisb@netflix.com>
|
@anotherchrisberry sounds good. |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 5, 2019
ecb2dd1 feat(gce): Support new artifact model for deploy SG (spinnaker#7178) c93b4d0 fix(executions): Clarify why executions are NOT_STARTED (spinnaker#7183) 1f3882b fix(core/pipeline): Change 'pipelines' state to redirect to the default child 'executions' ... instead of having an abstract state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are sometimes confused why their executions are "stuck" in
NOT_STARTEDstate and it's usually because there is aRUNNINGexecution and the pipeline is configured with concurrent executions disabled (the default).This change just explains it better when
limitConcurrentistrue. As a bonus, clickingRUNNINGalso links to executions filtered to running executions of the pipeline in question (there should only be one):