feat(gce): Support new artifact model for deploy SG #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refactored the deploy SG to use the new artifacts rewrite and added the support for custom artifacts. corresponding PRS: artifacts rewrite: prewrite: |
maggieneterval
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
LGTM, thanks so much Jammy! Just to make sure I understand since I've actually never used artifacts in a GCE deploy workflow: the GCE image artifacts are currently represented as "custom" kinds, which are deprecated post-rewrite, so you added the CUSTOM_OBJECT kind in the PR to maintain backwards compatibility?
|
yes that is correct. According to the comments in the code it only used the custom artifact type. I have some suspicions it hasn't worked for awhile without the changes I made |
ezimanyi
approved these changes
Jul 3, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 5, 2019
ecb2dd1 feat(gce): Support new artifact model for deploy SG (spinnaker#7178) c93b4d0 fix(executions): Clarify why executions are NOT_STARTED (spinnaker#7183) 1f3882b fix(core/pipeline): Change 'pipelines' state to redirect to the default child 'executions' ... instead of having an abstract state
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 15, 2019
ad483a0 fix(google): replace stateful MIG image input with dropdown (spinnaker#7210) 97db30b perf(google): improve performance of GCE image selection (spinnaker#7208) f340b02 feat(google): support stateful MIG operations (spinnaker#7196) ecb2dd1 feat(gce): Support new artifact model for deploy SG (spinnaker#7178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.