fix(k8s/runJob): null property file if value none (#7243) #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the logs capture selector changes to `none` we should null out the `propertyFile` field. the `consumeArtifactSource` field is used as a flag for deck to determine which option is selected but it isn't taken into account in orca. so, if `propertyFile` is non-null, orca will still try to find properties even if we have `consumeArtifactSource = none`. Fixes spinnaker/spinnaker#4642
ethanfrogers
deleted the
auto-cherry-pick-1.15-af4a1ad9d2bc66922ddd0127c05725670893e29a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the logs capture selector changes to
nonewe should null out thepropertyFilefield. theconsumeArtifactSourcefield is used as aflag for deck to determine which option is selected but it isn't taken
into account in orca. so, if
propertyFileis non-null, orca will stilltry to find properties even if we have
consumeArtifactSource = none.Fixes spinnaker/spinnaker#4642