Skip to content

Commit

Permalink
fix(k8s/runJob): null property file if value none (#7243) (#7246)
Browse files Browse the repository at this point in the history
if the logs capture selector changes to `none` we should null out the
`propertyFile` field. the `consumeArtifactSource` field is used as a
flag for deck to determine which option is selected but it isn't taken
into account in orca. so, if `propertyFile` is non-null, orca will still
try to find properties even if we have `consumeArtifactSource = none`.

Fixes spinnaker/spinnaker#4642
  • Loading branch information
spinnakerbot authored and ethanfrogers committed Jul 22, 2019
1 parent 5041dde commit 21ff047
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ export class KubernetesV2RunJobStageConfig extends React.Component<IStageConfigP

private sourceChanged = (event: any) => {
this.props.updateStageField({ consumeArtifactSource: event.value });
if (event.value === 'none') {
this.props.updateStageField({ propertyFile: null });
}
};

private updateArtifactId(artifactId: string) {
Expand Down

0 comments on commit 21ff047

Please sign in to comment.