feat(core): filter out providers that don't support creating security groups #7370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggieneterval
approved these changes
Oct 7, 2019
app/scripts/modules/core/src/securityGroup/AllSecurityGroupsCtrl.js
Outdated
Show resolved
Hide resolved
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 7, 2019
3192f2c fix(core/pipeline): When a trigger is updated, replace the entire object (spinnaker#7496) 64e47b4 feat(core): filter out providers that don't support creating security groups (spinnaker#7370) 2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
… groups (spinnaker#7370) * feat(core): filter out providers that don't support creating security groups
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
3192f2c fix(core/pipeline): When a trigger is updated, replace the entire object (spinnaker#7496) 64e47b4 feat(core): filter out providers that don't support creating security groups (spinnaker#7370) 2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow some providers' security group support to be 'read only': viewing the existing security groups is supported, but new security groups cannot be created through Spinnaker.
Fixes spinnaker/spinnaker#3794
Today this only covers the ECS provider: security groups can be created through the associated AWS account with the AWS provider's security group creation flow, instead of duplicating that flow in the ECS provider.
The result of this change is that for a Spinnaker instance with AWS and ECS providers enabled, the 'Create Firewall' button goes straight to the AWS provider modal, instead of allowing a choice between the AWS and ECS provider.
But both AWS and ECS security groups are still shown in the list view: