fix(core): Separate how config and plans are updated, add tests #7491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisjimenez
commented
Oct 4, 2019
| @@ -126,6 +126,7 @@ <h3> | |||
| <div class="pipeline-contents"> | |||
| <pipeline-config-view | |||
| application="application" | |||
| is-v2-templated-pipeline="isV2TemplatedPipeline" | |||
There was a problem hiding this comment.
this is the only change in this file, the rest is formatting
louisjimenez
force-pushed
the
louis/template-testing
branch
from
65615e0
to
db28b82
Compare
louisjimenez
force-pushed
the
louis/template-testing
branch
from
db28b82
to
a3d2580
Compare
erikmunson
approved these changes
Oct 5, 2019
|
@spinnakerbot cherry-pick 1.16 |
|
Cherry pick failed: Command failed (cherry pick commit 2ef8788) with exit code 1: |
louisjimenez
added a commit
to louisjimenez/deck
that referenced
this pull request
Oct 7, 2019
louisjimenez
added a commit
that referenced
this pull request
Oct 7, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 7, 2019
3192f2c fix(core/pipeline): When a trigger is updated, replace the entire object (spinnaker#7496) 64e47b4 feat(core): filter out providers that don't support creating security groups (spinnaker#7370) 2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491)
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 7, 2019
2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481)
christopherthielen
added a commit
that referenced
this pull request
Oct 7, 2019
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
3192f2c fix(core/pipeline): When a trigger is updated, replace the entire object (spinnaker#7496) 64e47b4 feat(core): filter out providers that don't support creating security groups (spinnaker#7370) 2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
2ef8788 fix(core): Separate how config and plans are updated, add tests (spinnaker#7491) 3c08b38 feat(core/presentation): Migrate ValidationMessage to new CSS styles (spinnaker#7481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some testing for configuring v2 templated pipelines.
It also make sure that the pipeline config shown when editing as JSON does not display inherited items and only shows what is directly saved to the config. To see the pipeline plan, including its inherited template items, the user can go into the "Rendered Pipeline" view.
spinnaker/spinnaker#4887