feat(core/managed): Add resource dropdown with links to history + source JSON #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
commented
Sep 4, 2019
| @@ -12,35 +15,75 @@ export interface IManagedResourceDetailsIndicatorProps { | |||
| entityTags: IEntityTags[]; | |||
| } | |||
|
|
|||
| const logClick = (label: string, resourceId: string) => | |||
There was a problem hiding this comment.
also some usage tracking for fun.
gcomstock
reviewed
Sep 4, 2019
| text-shadow: 0px 1px 4px rgba(0, 0, 0, 0.5); | ||
| padding-right: 5px; | ||
| } | ||
|
|
||
| .ManagedResourceDetailsIndicator .summary-message { | ||
| cursor: help; |
christopherthielen
approved these changes
Sep 4, 2019
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Sep 5, 2019
d8f1a51 fix(triggers): Protecting from undefined triggers (spinnaker#7377) ad4c144 feat(core/managed): Add resource dropdown with links to history + source JSON (spinnaker#7376) 3665d3e fix(typos): fix a few typos in help messages (spinnaker#7373)
alanmquach
added a commit
that referenced
this pull request
Sep 5, 2019
* chore(core): Bump version to 0.0.406 d8f1a51 fix(triggers): Protecting from undefined triggers (#7377) ad4c144 feat(core/managed): Add resource dropdown with links to history + source JSON (#7376) 3665d3e fix(typos): fix a few typos in help messages (#7373) * chore(amazon): Bump version to 0.0.209 373f581 fix(titus): Removing NLB as it is not compatible with Titus (#7317)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* chore(core): Bump version to 0.0.406 d8f1a51 fix(triggers): Protecting from undefined triggers (spinnaker#7377) ad4c144 feat(core/managed): Add resource dropdown with links to history + source JSON (spinnaker#7376) 3665d3e fix(typos): fix a few typos in help messages (spinnaker#7373) * chore(amazon): Bump version to 0.0.209 373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a couple bits of data about a resource we expect folks to care about early on: the event history of a resource, and the underlying config/definition for the resource that Keel has on file. This adds a dropdown to managed resources in the infrastructure views that lets folks see both, as new tabs with the raw JSON payload (opting for JSON instead of YAML to start, as we already do that across spinnaker and JSON is easy to use with the API ad-hoc). Design is quick and dirty for now, as we're not sure what we'll need in the coming months.