fix(titus): Removing NLB as it is not compatible with Titus #7317

alanmquach · 2019-08-12T23:40:06Z

No description provided.

Update master

erikmunson

This looks ok to me, though it feels a bit gross to put user facing Titus-aware stuff in the Amazon provider. I suspect you'd have to architect some pretty involved abstraction thing to avoid that so I have no issue with it as-is.

erikmunson · 2019-08-12T23:44:32Z

app/scripts/modules/amazon/src/loadBalancer/configure/AmazonLoadBalancerChoiceModal.tsx

+              <div className="alert alert-warning">
+                <p>
+                  <i className="fa fa-exclamation-triangle" /> Note: Classic Load Balancers cannot be used with Titus as
+                  they do not have <em>ip</em> based target groups.


Suggested change

they do not have <em>ip</em> based target groups.

they do not have <em>IP</em> based target groups.

Co-Authored-By: Erik Munson <erik@ipsumcreative.com>

alanmquach · 2019-08-12T23:53:13Z

Yeah, I don't like that either. Looking to see if there's an easy way to fork out and have this live in Titus instead.

…o incompatible-warning

alanmquach · 2019-08-13T01:05:48Z

app/scripts/modules/titus/src/titus.module.ts

+      {
+        CreateLoadBalancerModal: TitusLoadBalancerChoiceModal,
+      },
+      CloudProviderRegistry.getProvider('aws').loadBalancer,


@erikmunson I like this better, but I have mixed feelings about getting the the aws loadBalancer object from the CloudProviderRegistry vs importing it directly

ugghhhh, this is not great either because now for applications with both aws and titus configured, users are now asked to pick a provider because titus is not 100% delegated to aws

erikmunson

tiny typo but otherwise seems very reasonable, we had a conversation about whether to filter out the CLB option altogether and will leave that to your judgement.

erikmunson · 2019-08-13T18:10:28Z

app/scripts/modules/amazon/src/loadBalancer/configure/AmazonLoadBalancerChoiceModal.tsx

@@ -5,21 +5,29 @@ import { ILoadBalancerModalProps, ModalClose, ReactModal, noop } from '@spinnake

 import { IAmazonLoadBalancerConfig, LoadBalancerTypes } from './LoadBalancerTypes';

+export interface IAmazonLoadBalancerChoiceModalDetailsInectedProps {


s/Inected/Injected

373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317) f0d3254 refactor(titus): Making service job processes human friendly (spinnaker#7350)

* chore(core): Bump version to 0.0.405 6a47557 refactor(core): Reactify rename pipeline modal (#7368) 0d88644 feat(notifications): Add additional fields for Github and get config from halyard (#7239) 902c0b3 refactor(core): use a fieldLayout for manualExecution (#7356) 9f5a860 fix(core/pipeline): fix date picker for manual execution parameters where constraint == 'date' 744cf19 feat(core/presentation): Add DayPickerInput form input component 5a354b1 feat(core): improve readability of pipeline cancellation message (#7369) b889857 fix(artifacts): fix uncaught undefined exception with artifacts (#7362) dc16166 fix(core): Fix shadowed var usage (#7367) 5d1facd refactor(core): Reactify lock and unlock pipeline modal (#7366) d131e01 fix(core): separate multiple task errors by newline (#7355) 450d681 refactor(core): Reactify enable pipeline modal (#7360) 5155ba1 refactor(core): Reactify disable pipeline modal (#7358) 14035ae fix(kustomize): fix artifact selector (#7359) 12f2eaa refactor(core): Reactify delete pipeline modal (#7357) 48b7195 fix(kubernetes): add StageFailureMessage to Bake Manifest execution details (#7354) 5fae6ef feat(core): add stage status precondition type (#7348) f42977f fix(core): pipeline execution was not displaying all resolvedArtifacts (#7353) 251250b fix(artifacts/k8s): fix rewrite k8s artifact edit (#7352) * chore(titus): Bump version to 0.0.109 373f581 fix(titus): Removing NLB as it is not compatible with Titus (#7317) f0d3254 refactor(titus): Making service job processes human friendly (#7350)

373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317)

* chore(core): Bump version to 0.0.406 d8f1a51 fix(triggers): Protecting from undefined triggers (#7377) ad4c144 feat(core/managed): Add resource dropdown with links to history + source JSON (#7376) 3665d3e fix(typos): fix a few typos in help messages (#7373) * chore(amazon): Bump version to 0.0.209 373f581 fix(titus): Removing NLB as it is not compatible with Titus (#7317)

…pinnaker#7317)" This reverts commit 373f581.

…r#7317)

* chore(core): Bump version to 0.0.405 6a47557 refactor(core): Reactify rename pipeline modal (spinnaker#7368) 0d88644 feat(notifications): Add additional fields for Github and get config from halyard (spinnaker#7239) 902c0b3 refactor(core): use a fieldLayout for manualExecution (spinnaker#7356) 9f5a860 fix(core/pipeline): fix date picker for manual execution parameters where constraint == 'date' 744cf19 feat(core/presentation): Add DayPickerInput form input component 5a354b1 feat(core): improve readability of pipeline cancellation message (spinnaker#7369) b889857 fix(artifacts): fix uncaught undefined exception with artifacts (spinnaker#7362) dc16166 fix(core): Fix shadowed var usage (spinnaker#7367) 5d1facd refactor(core): Reactify lock and unlock pipeline modal (spinnaker#7366) d131e01 fix(core): separate multiple task errors by newline (spinnaker#7355) 450d681 refactor(core): Reactify enable pipeline modal (spinnaker#7360) 5155ba1 refactor(core): Reactify disable pipeline modal (spinnaker#7358) 14035ae fix(kustomize): fix artifact selector (spinnaker#7359) 12f2eaa refactor(core): Reactify delete pipeline modal (spinnaker#7357) 48b7195 fix(kubernetes): add StageFailureMessage to Bake Manifest execution details (spinnaker#7354) 5fae6ef feat(core): add stage status precondition type (spinnaker#7348) f42977f fix(core): pipeline execution was not displaying all resolvedArtifacts (spinnaker#7353) 251250b fix(artifacts/k8s): fix rewrite k8s artifact edit (spinnaker#7352) * chore(titus): Bump version to 0.0.109 373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317) f0d3254 refactor(titus): Making service job processes human friendly (spinnaker#7350)

* chore(core): Bump version to 0.0.406 d8f1a51 fix(triggers): Protecting from undefined triggers (spinnaker#7377) ad4c144 feat(core/managed): Add resource dropdown with links to history + source JSON (spinnaker#7376) 3665d3e fix(typos): fix a few typos in help messages (spinnaker#7373) * chore(amazon): Bump version to 0.0.209 373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317)

alanmquach added 2 commits July 2, 2019 23:57

Merge pull request #3 from spinnaker/master

611d35e

Update master

fix(titus): Warning users that CLBs do not work with Titus

77d5768

alanmquach requested review from erikmunson and christopherthielen August 12, 2019 23:40

erikmunson reviewed Aug 12, 2019

View reviewed changes

fix(titus): Warning users that CLBs do not work with Titus

9149685

Co-Authored-By: Erik Munson <erik@ipsumcreative.com>

alanmquach added 3 commits August 12, 2019 17:58

fix(titus): Warning users that CLBs do not work with Titus

2b4d515

Merge github.com:alanmquach/deck into incompatible-warning

8e36079

Merge branch 'incompatible-warning' of github.com:alanmquach/deck int…

0d665ca

…o incompatible-warning

alanmquach commented Aug 13, 2019

View reviewed changes

erikmunson reviewed Aug 13, 2019

View reviewed changes

christopherthielen approved these changes Aug 14, 2019

View reviewed changes

alanmquach added 3 commits August 21, 2019 16:37

Merge branch 'master' into incompatible-warning

62f979d

Merge branch 'master' into incompatible-warning

606a09f

fix(titus): Removing NLB as it is not compatible with Titus

deb0cae

alanmquach changed the title ~~fix(titus): Warning users that CLBs do not work with Titus~~ fix(titus): Removing NLB as it is not compatible with Titus Aug 27, 2019

Merge branch 'master' into incompatible-warning

194bb23

alanmquach merged commit 373f581 into spinnaker:master Sep 3, 2019

alanmquach deleted the incompatible-warning branch September 3, 2019 18:03

spinnakerbot added the target-release/1.16 label Sep 3, 2019

alanmquach mentioned this pull request Sep 3, 2019

Bump package core to 0.0.405 and titus to 0.0.109 #7372

Merged

alanmquach added a commit to alanmquach/deck that referenced this pull request Sep 5, 2019

chore(amazon): Bump version to 0.0.209

e39c0f2

373f581 fix(titus): Removing NLB as it is not compatible with Titus (spinnaker#7317)

alanmquach mentioned this pull request Sep 5, 2019

Bump package core to 0.0.406 and amazon to 0.0.209 #7378

Merged

alanmquach added a commit to alanmquach/deck that referenced this pull request Sep 12, 2019

Revert "fix(titus): Removing NLB as it is not compatible with Titus (s…

2b50334

…pinnaker#7317)" This reverts commit 373f581.

spinnakerbot mentioned this pull request Sep 12, 2019

refactor(titus): Adding load balancer incompatibility #7386

Merged

yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021

fix(titus): Removing NLB as it is not compatible with Titus (spinnake…

1aaaf1a

…r#7317)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(titus): Removing NLB as it is not compatible with Titus #7317

fix(titus): Removing NLB as it is not compatible with Titus #7317

alanmquach commented Aug 12, 2019

erikmunson left a comment

erikmunson Aug 12, 2019

alanmquach commented Aug 12, 2019

alanmquach Aug 13, 2019

alanmquach Aug 13, 2019

erikmunson left a comment

erikmunson Aug 13, 2019

	they do not have <em>ip</em> based target groups.
	they do not have <em>IP</em> based target groups.

		@@ -5,21 +5,29 @@ import { ILoadBalancerModalProps, ModalClose, ReactModal, noop } from '@spinnake

		import { IAmazonLoadBalancerConfig, LoadBalancerTypes } from './LoadBalancerTypes';

		export interface IAmazonLoadBalancerChoiceModalDetailsInectedProps {

fix(titus): Removing NLB as it is not compatible with Titus #7317

fix(titus): Removing NLB as it is not compatible with Titus #7317

Conversation

alanmquach commented Aug 12, 2019

erikmunson left a comment

Choose a reason for hiding this comment

erikmunson Aug 12, 2019

Choose a reason for hiding this comment

alanmquach commented Aug 12, 2019

alanmquach Aug 13, 2019

Choose a reason for hiding this comment

alanmquach Aug 13, 2019

Choose a reason for hiding this comment

erikmunson left a comment

Choose a reason for hiding this comment

erikmunson Aug 13, 2019

Choose a reason for hiding this comment