feat(ui): Show health check url beside target group #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
christopherthielen
approved these changes
Oct 11, 2019
|
|
||
| export const getAllTargetGroups = loadBalancers => { | ||
| const allTargetGroups = loadBalancers.map(d => d.targetGroups); | ||
| const targetGroups = flatten(allTargetGroups).reduce((groups, tg) => { |
There was a problem hiding this comment.
could use keyBy from lodash instead of a custom reducer here
|
|
||
| // augment with target group healthcheck data | ||
| const targetGroups = getAllTargetGroups(app.loadBalancers.data); | ||
| getTargetGroupHealthCheckInfo(displayableMetrics, targetGroups); |
There was a problem hiding this comment.
if we are going to mutate data in a function, I'd like the function name to indicate this. I was confused because there was a get method but I didn't see the return value used.
Perhaps something like applyHealthcheckInfoToTargetGroups?
| @@ -145,6 +145,15 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click> | |||
| ng-repeat="targetGroup in metric.targetGroups" | |||
| > | |||
| <instance-load-balancer-health load-balancer="targetGroup"></instance-load-balancer-health> | |||
| <span class="pad-left small"> | |||
There was a problem hiding this comment.
Would it be possible to move this markup into the instanceLoadBalancerHealth component?
There was a problem hiding this comment.
Yes definitely possible. This component is also used for LoadBalancer type health metrics, so I will hide this segment if the url is not present.
caseyhebebrand
force-pushed
the
target-group-health
branch
2 times, most recently
from
66a3e9a
to
18ff930
Compare
| </OverlayTrigger> | ||
| ); | ||
| } | ||
|
|
||
| return healthDiv; | ||
| return ( | ||
| <React.Fragment> |
There was a problem hiding this comment.
I think we generally only use <React.Fragment> if we need to add a key prop. We use the short version most other places: <>
| @@ -31,7 +31,8 @@ | |||
| "paths": { | |||
| "@spinnaker/core": ["."], | |||
| "core/*": ["*"], | |||
| "core": ["."] | |||
| "core": ["."], | |||
| "@spinnaker/amazon": ["../../amazon/lib"] | |||
There was a problem hiding this comment.
this dependency should be removed
caseyhebebrand
force-pushed
the
target-group-health
branch
from
ed7dfe7
to
4940f6a
Compare
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 16, 2019
c8c06e4 fix(artifact/bitbucket): Bitbucket Use Default Artifact (spinnaker#7523) ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 16, 2019
ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 16, 2019
c8c06e4 fix(artifact/bitbucket): Bitbucket Use Default Artifact (spinnaker#7523) ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 16, 2019
ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
caseyhebebrand
added a commit
to caseyhebebrand/deck
that referenced
this pull request
Oct 16, 2019
ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
christopherthielen
pushed a commit
that referenced
this pull request
Oct 16, 2019
erikmunson
pushed a commit
that referenced
this pull request
Oct 23, 2019
Turns out that the `<OverlayTrigger>` component needs whatever you give it as children to be a single node. With the change introduced in #7520, the code path that runs when the health status is `UP` works fine, but any non-UP status hits the `<OverlayTrigger>` path and blows up/fails to render because there's two root nodes. This just wraps those two nodes in a fragment.
This was referenced Oct 23, 2019
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2019
Turns out that the `<OverlayTrigger>` component needs whatever you give it as children to be a single node. With the change introduced in #7520, the code path that runs when the health status is `UP` works fine, but any non-UP status hits the `<OverlayTrigger>` path and blows up/fails to render because there's two root nodes. This just wraps those two nodes in a fragment.
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
c8c06e4 fix(artifact/bitbucket): Bitbucket Use Default Artifact (spinnaker#7523) ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
ed7c445 feat(ui): Show health check url beside target group (spinnaker#7520)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…r#7555) Turns out that the `<OverlayTrigger>` component needs whatever you give it as children to be a single node. With the change introduced in spinnaker#7520, the code path that runs when the health status is `UP` works fine, but any non-UP status hits the `<OverlayTrigger>` path and blows up/fails to render because there's two root nodes. This just wraps those two nodes in a fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a health check link next to the Target Group in Status section of the instance's details.
After:
