fix(kubernetes): disable project cluster filtration by stack/detail #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 28, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571) 629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569) ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568) e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567) 114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562) 86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536) 6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
christopherthielen
added a commit
that referenced
this pull request
Oct 28, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (#7571) 629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (#7569) ca176fc feat(provider/aws): Functions (listing and searching) (#7568) e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (#7536)" (#7567) 114303a fix(kubernetes): disable project cluster filtration by stack/detail (#7562) 86a365b feat(provider/aws): Functions (listing and searching) (#7536) 6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (#7563)
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571) 629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569) ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568) e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567) 114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562) 86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536) 6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571) 629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569) ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568) e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567) 114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562) 86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536) 6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes spinnaker/spinnaker#4880, spinnaker/spinnaker#3490
When configuring a Spinnaker project with Kubernetes V2 accounts, only filtering by
*for stack and detail will return any clusters. This is because unlike with the VM-based providers, an application cluster itself is not associated with a single stack/detail, and each of its workloads can be associated with different stacks/details depending on the moniker annotations added to each manifest. This violates some assumptions in the Clouddriver logic shared by all providers and would be non-trivial to fix. We brought this issues to the SIG and there was not a ton of interest in further investment in the Projects view at this time, so this fix is a bandaid so at least the limitations of configuring projects with Kubernetes V2 accounts is clear at configuration time.