Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider/aws): Functions (listing and searching) #7568

Merged
merged 14 commits into from
Oct 25, 2019

Conversation

sidmuls
Copy link
Contributor

@sidmuls sidmuls commented Oct 25, 2019

Issue: https://github.com/spinnaker/spinnaker/issues/4921Issue
Summary:
Add functions support to Spinnaker UI. This is a net functionality that we've been working on for almost a year to this point. The initial backend work was done like three months back.
From then we've worked on creating the UI components with guidance from the Netflix UX team.

Cloud Provider(s): provider/AWS
Environment:
This worked on user's local environment and also through deploying docker images to kubernetes cluster.

Feature Area: @spinnaker/ui-ux-team
Description:
CRUD functionality for managing lambda functions, With this new we must be able to create, update and delete lambda lambda functions through Spinnaker UI
We must also be able to attach target groups to lambda functions using Spinnaker UI.
Additional Details:
Clouddriver backend details: https://github.com/spinnaker/clouddriver/tree/master/clouddriver-lambda

sidmuls and others added 13 commits October 16, 2019 02:03
This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe
This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe
…tion component.

This is a refactoring change as requested by reviewer @caseyhebebrand

Author: @sidmuls
This change is for refactoring requested by reviewer @caseyhebebrand.

Author: @sidmuls
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • c7d0768: .

  • d1b43d2: refactor(provider/aws): removing extra line. Tthis is actually for retrying tests on TravisCI

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled this down and ran it locally, feature flagging seems to have fixed the issues with data sources and I'm told by @sidmuls that if the backend has functions turned on the endpoint this code hits will return an empty array, so I'm satisfied. Thanks for adding the flag as requested!

@erikmunson erikmunson added the ready to merge Reviewed and ready for merge label Oct 25, 2019
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 25, 2019
@mergify mergify bot merged commit ca176fc into spinnaker:master Oct 25, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 28, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571)
629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 28, 2019
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
christopherthielen added a commit that referenced this pull request Oct 28, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (#7571)
629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (#7569)
ca176fc feat(provider/aws): Functions (listing and searching) (#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (#7536)" (#7567)
114303a fix(kubernetes): disable project cluster filtration by stack/detail (#7562)
86a365b feat(provider/aws): Functions (listing and searching) (#7536)
6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (#7563)
christopherthielen added a commit that referenced this pull request Oct 28, 2019
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (#7536)" (#7567)
86a365b feat(provider/aws): Functions (listing and searching) (#7536)
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
* .

* feat(provider/aws): Function listing and searching functionality

This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe

* feat(provider/aws): Function listing and searching functionality

This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe

* refactor(provider/aws): Converting Function class component into function component.

This is a refactoring change as requested by reviewer @caseyhebebrand

Author: @sidmuls

* refactor(provider/aws): Refactoring groupings into a separate component.

This change is for refactoring requested by reviewer @caseyhebebrand.

Author: @sidmuls

* refactor(provider/aws): Removing unnecessary state from FunctionGroupings.

This change is a refactoring requested by @caseyhebebrand

Author: @sidmuls

*  refactor(provider/aws): removing extra line. Tthis is actually for retrying tests on TravisCI

* refactor(provider/aws): Adding tests for FunctionFilterService and changes as requested by @christopherthielen

Author: @sidmuls

* refactor(provider/aws): removing unnecessary field from IFunction

* refactor(provider/aws): adding flag to turn off functions feature
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571)
629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
* .

* feat(provider/aws): Function listing and searching functionality

This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe

* feat(provider/aws): Function listing and searching functionality

This change adds a new tab for functions and facilitates listing existing functions and searching functions listed.
Corresponding provider specific changes are included in this change for AWS.

Authors: @sidmuls and @nabebe

* refactor(provider/aws): Converting Function class component into function component.

This is a refactoring change as requested by reviewer @caseyhebebrand

Author: @sidmuls

* refactor(provider/aws): Refactoring groupings into a separate component.

This change is for refactoring requested by reviewer @caseyhebebrand.

Author: @sidmuls

* refactor(provider/aws): Removing unnecessary state from FunctionGroupings.

This change is a refactoring requested by @caseyhebebrand

Author: @sidmuls

*  refactor(provider/aws): removing extra line. Tthis is actually for retrying tests on TravisCI

* refactor(provider/aws): Adding tests for FunctionFilterService and changes as requested by @christopherthielen

Author: @sidmuls

* refactor(provider/aws): removing unnecessary field from IFunction

* refactor(provider/aws): adding flag to turn off functions feature
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
d71daa5 fix(core/pipeline): fully re-render list of trigger configs after a delete (spinnaker#7571)
629a98f fix(core/pipeline): make revision dropdown usable, layout tweaks (spinnaker#7569)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
114303a fix(kubernetes): disable project cluster filtration by stack/detail (spinnaker#7562)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
6236a9f fix(core/pipeline): make UX less bad when a pipeline stage never happened (spinnaker#7563)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants