Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/pipeline): Use markdown to render evaluated variables as JSON #7628

Merged
merged 2 commits into from
Nov 12, 2019
Merged

fix(core/pipeline): Use markdown to render evaluated variables as JSON #7628

merged 2 commits into from
Nov 12, 2019

Conversation

christopherthielen
Copy link
Contributor

Screen Shot 2019-11-11 at 4 51 41 PM

alanmquach
alanmquach approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@alanmquach alanmquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@christopherthielen christopherthielen added the ready to merge Reviewed and ready for merge label Nov 12, 2019
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 12, 2019
@mergify mergify bot merged commit e4b432d into spinnaker:master Nov 12, 2019
@christopherthielen christopherthielen deleted the evaluate-variables-render-as-markdown branch November 12, 2019 01:32
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Nov 12, 2019
@christopherthielen
chore(core): Bump version to 0.0.432
401d467 
e4b432d fix(core/pipeline): Use markdown to render evaluated variables as JSON (spinnaker#7628)
f93a278 test(core/presentation): Re-add removed isInitialValid logic (spinnaker#7627)
956b43b feat(provider/aws): Function create/update/delete feature. (spinnaker#7586)
@christopherthielen christopherthielen mentioned this pull request Nov 12, 2019
Merged
christopherthielen added a commit that referenced this pull request Nov 12, 2019
@christopherthielen
chore(core): Bump version to 0.0.432
6fdd331 
e4b432d fix(core/pipeline): Use markdown to render evaluated variables as JSON (#7628)
f93a278 test(core/presentation): Re-add removed isInitialValid logic (#7627)
956b43b feat(provider/aws): Function create/update/delete feature. (#7586)
erikmunson
erikmunson reviewed Nov 12, 2019
View reviewed changes
Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice 💅

@maggieneterval maggieneterval mentioned this pull request Dec 27, 2019
Closed
sergiopena pushed a commit to sergiopena/deck that referenced this pull request Jan 10, 2020
@christopherthielen @sergiopena
fix(core/pipeline): Use markdown to render evaluated variables as JSON (
63462bc 
spinnaker#7628)
sergiopena pushed a commit to sergiopena/deck that referenced this pull request Jan 10, 2020
@christopherthielen @sergiopena
chore(core): Bump version to 0.0.432
54f48b8 
e4b432d fix(core/pipeline): Use markdown to render evaluated variables as JSON (spinnaker#7628)
f93a278 test(core/presentation): Re-add removed isInitialValid logic (spinnaker#7627)
956b43b feat(provider/aws): Function create/update/delete feature. (spinnaker#7586)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@christopherthielen @yunzhangit
fix(core/pipeline): Use markdown to render evaluated variables as JSON (
8a93d90 
spinnaker#7628)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@christopherthielen @yunzhangit
chore(core): Bump version to 0.0.432
0340dd4 
e4b432d fix(core/pipeline): Use markdown to render evaluated variables as JSON (spinnaker#7628)
f93a278 test(core/presentation): Re-add removed isInitialValid logic (spinnaker#7627)
956b43b feat(provider/aws): Function create/update/delete feature. (spinnaker#7586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmunson erikmunson erikmunson left review comments

@alanmquach alanmquach alanmquach approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.18
Projects
None yet
Milestone
No milestone
4 participants
@christopherthielen @alanmquach @erikmunson @spinnakerbot