Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure,gce): Fix typo breaking bake stage #7631

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

alanmquach
Copy link
Contributor

Somehow ended up with the string SETTINGS.feature.roscoMode duplicated, probably while copy/pasting #7564 to other providers resulting in

SETTINGS.feature.roscoModeSETTINGS.feature.roscoMode

Which causes a javascript exception trying to access the second feature because SETTINGS.feature.roscoModeSETTINGS is likely never defined.

@alanmquach alanmquach merged commit 0a4f315 into spinnaker:master Nov 12, 2019
@alanmquach alanmquach deleted the fix-bakes branch November 12, 2019 20:14
@maggieneterval
Copy link
Contributor

@spinnakerbot 🍒 ⛏ 1.17

@maggieneterval
Copy link
Contributor

@spinnakerbot cherry-pick 1.17

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7639

sergiopena pushed a commit to sergiopena/deck that referenced this pull request Jan 10, 2020
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants