Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rosco): Allow roscoMode per stage/execution #7564

Merged
merged 3 commits into from
Oct 25, 2019
Merged

feat(rosco): Allow roscoMode per stage/execution #7564

merged 3 commits into from
Oct 25, 2019

Conversation

alanmquach
Copy link
Contributor

This allows deck to be configured to compute roscoMode on a per stage/execution basis via an optional roscoSelector in settings:

roscoMode: false,
roscoSelector: (stage) => stage && stage.roscoMode,
snapshots: false,

asher
asher approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@asher asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

erikmunson
erikmunson reviewed Oct 25, 2019
View reviewed changes
app/scripts/modules/amazon/src/pipeline/stages/bake/awsBakeStage.js
$scope.baseOsOptions.push({
id: $scope.stage.baseOs,
detailedDescription: 'Custom',
vmTypes: ['hvm', 'pv'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hey this is kind of a cool idea. only downside is it means we lose the ability to validate OS options that we remove because they're deprecated. but maybe that's ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the current experience is terrible because it just JSEs.

If we wanted to aggressively validate against deprecated versions, I’d imagine we can return a “deprecated” blacklist or flag from the gate endpoint.

But not sure it’s worth that effort.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i went through basically the same thought process — i think this is good enough until we decide we need some kind of deprecated indicator

erikmunson
erikmunson approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@erikmunson erikmunson added the ready to merge Reviewed and ready for merge label Oct 25, 2019
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 25, 2019
@mergify mergify bot merged commit c2bbf20 into spinnaker:master Oct 25, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 28, 2019
@christopherthielen
chore(amazon): Bump version to 0.0.220
4c3f5f7 
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
@christopherthielen christopherthielen mentioned this pull request Oct 28, 2019
Merged
christopherthielen added a commit that referenced this pull request Oct 28, 2019
@christopherthielen
chore(amazon): Bump version to 0.0.220
97ed519 
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (#7536)" (#7567)
86a365b feat(provider/aws): Functions (listing and searching) (#7536)
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
@alanmquach
feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
c22ea6c 
* fix(awsbake): Fix exception if an unlisted baseOs is used

* feat(bake): Support roscoSelector(stage) to determine roscoMode
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Nov 8, 2019
@christopherthielen
chore(amazon): Bump version to 0.0.220
f91f055 
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
@mybayern1974
Copy link
Contributor

@alanmquach, the Azure provider breaks since Spinnaker version 1.17 and per our tier 1 investigation, this PR might be the root cause. More detail about Azure experience breaking see issue 5104. Could you please help take a look?
@duftler, @maggieneterval , given Azure is now broken, it's expected there will be a patch version release at the earliest date after the above issue got fixed.
@neil-yechenwei and @grayzu for awareness.

@alanmquach alanmquach mentioned this pull request Nov 12, 2019
Merged
@alanmquach
Copy link
Contributor Author

@mybayern1974 I just took a look and it looks like I accidentally duplicated the string SETTINGS.feature.roscoMode (resulting in SETTINGS.feature.roscoModeSETTINGS.feature.roscoMode). Sorry about that. I've just created #7631 which should fix it.

yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@alanmquach
feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
8c23393 
* fix(awsbake): Fix exception if an unlisted baseOs is used

* feat(bake): Support roscoSelector(stage) to determine roscoMode
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@christopherthielen
chore(amazon): Bump version to 0.0.220
88c5c32 
c2bbf20 feat(rosco): Allow roscoMode per stage/execution (spinnaker#7564)
ca176fc feat(provider/aws): Functions (listing and searching) (spinnaker#7568)
e49ffaf Revert "feat(provider/aws): Functions (listing and searching) (spinnaker#7536)" (spinnaker#7567)
86a365b feat(provider/aws): Functions (listing and searching) (spinnaker#7536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmunson erikmunson erikmunson approved these changes

@asher asher asher approved these changes

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu

@christopherthielen christopherthielen Awaiting requested review from christopherthielen

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alanmquach @mybayern1974 @asher @erikmunson @spinnakerbot