Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): catch cancelling of resource pause from server group modal #7764

Merged
merged 1 commit into from Jan 10, 2020
Merged

fix(core): catch cancelling of resource pause from server group modal #7764

merged 1 commit into from Jan 10, 2020

Conversation

anotherchrisberry
Copy link
Contributor

@anotherchrisberry anotherchrisberry commented Jan 10, 2020

A day will come when there is no Angular to yell about uncaught promise rejections

Copy link
Contributor

@caseyhebebrand caseyhebebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anotherchrisberry anotherchrisberry merged commit 86832e6 into spinnaker:master Jan 10, 2020
@anotherchrisberry anotherchrisberry deleted the pause-cancel-catch branch January 10, 2020 17:55
erikmunson pushed a commit that referenced this pull request Jan 10, 2020
fix(core/pipeline): use fresh trigger + stage list for upstream flag validation (#7765)
fix(core): catch cancelling of resource pause from server group modal (#7764)
mergify bot pushed a commit that referenced this pull request Jan 10, 2020
fix(core/pipeline): use fresh trigger + stage list for upstream flag validation (#7765)
fix(core): catch cancelling of resource pause from server group modal (#7764)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
fix(core/pipeline): use fresh trigger + stage list for upstream flag validation (spinnaker#7765)
fix(core): catch cancelling of resource pause from server group modal (spinnaker#7764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants