fix(artifacts): only remove deleted expected artifacts from stages on… #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinnakerbot 🍒 ⛏ 1.19 |
|
@spinnakerbot 🍒 ⛏ 1.18 |
|
@spinnakerbot 🍒 ⛏ 1.17 |
|
@spinnakerbot cherry-pick 1.19 |
|
@spinnakerbot cherry-pick 1.18 |
|
@spinnakerbot cherry-pick 1.17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 23, 2020
… trigger update (#8071)
|
Cherry pick successful: #8072 |
|
(I wasn't standing six feet away from spinnakerbot when I asked her to do the cherry-picks the first time. Sorry.) |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 23, 2020
… trigger update (#8071)
|
Cherry pick successful: #8073 |
|
Cherry pick failed: Command failed (cherry pick commit a47c627) with exit code 1: |
maggieneterval
added a commit
to maggieneterval/deck
that referenced
this pull request
Mar 23, 2020
maggieneterval
added a commit
to maggieneterval/deck
that referenced
this pull request
Mar 23, 2020
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… trigger update
Closes spinnaker/spinnaker#5573
With the
artifactsRewriteflag on, upon updating a trigger, all associated artifacts references are being removed from any downstream stages. This change makes it so only deleted artifacts' references are removed from downstream stages.This commit is intended to be cherry-picked to 1.19, 1.18, and 1.17. This change does not resolve a separate (but less destructive) bug where deleted artifact references are not removed from stages when the trigger that owns them is removed. That bug will be fixed as part of an upcoming more invasive refactor that will not be cherry-picked.