-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(artifacts): only remove deleted expected artifacts from stages on… #8071
fix(artifacts): only remove deleted expected artifacts from stages on… #8071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏺 🚫 ❓ 👍 : 👍
👩💻 🔨 🐛
@spinnakerbot 🍒 ⛏ 1.19 |
@spinnakerbot 🍒 ⛏ 1.18 |
@spinnakerbot 🍒 ⛏ 1.17 |
@spinnakerbot cherry-pick 1.19 |
@spinnakerbot cherry-pick 1.18 |
@spinnakerbot cherry-pick 1.17 |
… trigger update (#8071)
Cherry pick successful: #8072 |
(I wasn't standing six feet away from spinnakerbot when I asked her to do the cherry-picks the first time. Sorry.) |
… trigger update (#8071)
Cherry pick successful: #8073 |
Cherry pick failed: Command failed (cherry pick commit a47c627) with exit code 1:
|
… trigger update
Closes spinnaker/spinnaker#5573
With the
artifactsRewrite
flag on, upon updating a trigger, all associated artifacts references are being removed from any downstream stages. This change makes it so only deleted artifacts' references are removed from downstream stages.This commit is intended to be cherry-picked to 1.19, 1.18, and 1.17. This change does not resolve a separate (but less destructive) bug where deleted artifact references are not removed from stages when the trigger that owns them is removed. That bug will be fixed as part of an upcoming more invasive refactor that will not be cherry-picked.