Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mocks): Add mocks for IEntityTags types #8145

Merged
merged 2 commits into from
Apr 8, 2020
Merged

feat(mocks): Add mocks for IEntityTags types #8145

merged 2 commits into from
Apr 8, 2020

Conversation

caseyhebebrand
Copy link
Contributor

Mocks and mock generators for all types within IEntityTags domain.

vigneshm
vigneshm approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@vigneshm vigneshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@caseyhebebrand caseyhebebrand merged commit 8b1cc13 into spinnaker:master Apr 8, 2020
@caseyhebebrand caseyhebebrand deleted the mock-entity-tags branch April 15, 2020 04:15
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@caseyhebebrand @yunzhangit
feat(mocks): Add mocks for IEntityTags types (spinnaker#8145)
8c4281a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshm vigneshm vigneshm approved these changes

@erikmunson erikmunson erikmunson approved these changes

@alanmquach alanmquach Awaiting requested review from alanmquach

@christopherthielen christopherthielen Awaiting requested review from christopherthielen

Assignees
No one assigned
Labels
target-release/1.20
Projects
None yet
Milestone
No milestone
4 participants
@caseyhebebrand @vigneshm @erikmunson @spinnakerbot