feat(kubernetes): Add deployment status to Run Job stage UI #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggieneterval
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Thanks, @evansb! Appreciate that you tested this against your Spinnaker installation. And +1 to pulling out the DeployStatus component since it is no longer in use exclusively by the Deploy stage.
ethanfrogers
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#5793
This PR adds
Deploy Statustab to Run Job execution details. It does so by reusingDeployStatuscomponent from Deploy Manifest stage similar to Patch Manifest stage.I have done some manual testing against our Spinnaker installation.
There is a refactoring opportunity after this PR is merged since
DeployStatuswould have been used by 3 different components, it can be moved out fromdeployManifestdirectory since it is no longer internal to that stage.