perf(kubernetes): Send server group and firewall requests in parallel #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the change I just made for instances, let's request the details and the manifest at the same time so that we reduce the amount of time the user has to wait. For server group managers and load balancers, we are not making a request for the details at all, so we don't need to make the same change to those controllers.
maggieneterval
approved these changes
Aug 17, 2020
moki-daniel
pushed a commit
to moki-daniel/deck
that referenced
this pull request
Aug 28, 2020
…spinnaker#8500) Similar to the change I just made for instances, let's request the details and the manifest at the same time so that we reduce the amount of time the user has to wait. For server group managers and load balancers, we are not making a request for the details at all, so we don't need to make the same change to those controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the change I just made for instances, let's request the details and the manifest at the same time so that we reduce the amount of time the user has to wait.
For server group managers and load balancers, we are not making a request for the details at all, so we don't need to make the same change to those controllers.