fix(pluginsdk): Remove package.json 'module' lint rule from check-plugin #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshm
approved these changes
Oct 12, 2020
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Nov 10, 2020
feat(pluginsdk): Add 'yarn lint' script to package.json ([30fd60d](spinnaker@30fd60d)) feat(promiselike): Add then() and finally() methods to PromiseLike interface ([5886373](spinnaker@5886373)) feat(pluginsdk-peerdeps): Create a separate package for managing peer dependencies for plugins [spinnaker#8637](spinnaker#8637) ([c0897f1](spinnaker@c0897f1)) fix(pluginsdk): Remove package.json 'module' lint rule from check-plugin [spinnaker#8635](spinnaker#8635) ([98a16ea](spinnaker@98a16ea)) feat(pluginsdk): Add cli flags to scaffold.js to allow non-interactive scaffolding [spinnaker#8636](spinnaker#8636) ([5c84d68](spinnaker@5c84d68))
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Nov 10, 2020
feat(pluginsdk): Add 'yarn lint' script to package.json ([30fd60d](spinnaker@30fd60d)) feat(promiselike): Add then() and finally() methods to PromiseLike interface ([5886373](spinnaker@5886373)) feat(pluginsdk-peerdeps): Create a separate package for managing peer dependencies for plugins [spinnaker#8637](spinnaker#8637) ([c0897f1](spinnaker@c0897f1)) fix(pluginsdk): Remove package.json 'module' lint rule from check-plugin [spinnaker#8635](spinnaker#8635) ([98a16ea](spinnaker@98a16ea)) feat(pluginsdk): Add cli flags to scaffold.js to allow non-interactive scaffolding [spinnaker#8636](spinnaker#8636) ([5c84d68](spinnaker@5c84d68))
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Nov 10, 2020
feat(pluginsdk): Add 'yarn lint' script to package.json ([30fd60d](spinnaker@30fd60d)) feat(promiselike): Add then() and finally() methods to PromiseLike interface ([5886373](spinnaker@5886373)) feat(pluginsdk-peerdeps): Create a separate package for managing peer dependencies for plugins [spinnaker#8637](spinnaker#8637) ([c0897f1](spinnaker@c0897f1)) fix(pluginsdk): Remove package.json 'module' lint rule from check-plugin [spinnaker#8635](spinnaker#8635) ([98a16ea](spinnaker@98a16ea)) feat(pluginsdk): Add cli flags to scaffold.js to allow non-interactive scaffolding [spinnaker#8636](spinnaker#8636) ([5c84d68](spinnaker@5c84d68))
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
* chore(pluginsdk): publish 0.0.22 feat(pluginsdk): Add 'yarn lint' script to package.json ([30fd60d](30fd60d)) feat(promiselike): Add then() and finally() methods to PromiseLike interface ([5886373](5886373)) feat(pluginsdk-peerdeps): Create a separate package for managing peer dependencies for plugins [#8637](#8637) ([c0897f1](c0897f1)) fix(pluginsdk): Remove package.json 'module' lint rule from check-plugin [#8635](#8635) ([98a16ea](98a16ea)) feat(pluginsdk): Add cli flags to scaffold.js to allow non-interactive scaffolding [#8636](#8636) ([5c84d68](5c84d68)) * fix(pluginsdk): Fix peer deps lint rule * chore(pluginsdk): release 0.0.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deck plugins don't get published as an NPM package, no need for a
mainormoduleentry in the package.json, I suppose