Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazon/targetGroups): Handle empty healthCheckPath #8727

Merged
merged 2 commits into from Nov 11, 2020
Merged

fix(amazon/targetGroups): Handle empty healthCheckPath #8727

merged 2 commits into from Nov 11, 2020

Conversation

vigneshm
Copy link
Contributor

When healthCheckProtocol is TCP, the healthCheckPath value is empty and deck doesn't handle it well.

I'm wondering if we should also remove the link shown in InstanceLoadBalancerHealth since it is linking to tcp://...?

robzienert
robzienert approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@robzienert robzienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@christopherthielen
Copy link
Contributor

I'm wondering if we should also remove the link shown in InstanceLoadBalancerHealth since it is linking to tcp://...?

Perhaps we should still show the tcp:// but not render it in an anchor tag

@vigneshm vigneshm added the ready to merge Reviewed and ready for merge label Nov 11, 2020
@mergify mergify bot merged commit 5cd460e into spinnaker:master Nov 11, 2020
@vigneshm vigneshm deleted the fix-empty-healthCheckPath branch November 11, 2020 23:37
caseyhebebrand added a commit that referenced this pull request Nov 12, 2020
@caseyhebebrand
chore(amazon): publish amazon@0.0.280
0714eaf 
5cd460e fix(amazon/targetGroups): Handle empty healthCheckPath (#8727)
caseyhebebrand added a commit that referenced this pull request Nov 12, 2020
@caseyhebebrand
chore(core): publish core@0.0.529
31821ce 
f2c6b4f fix(core/instance): Optional copyable sshLink to InstanceDetailsHeader (#8728)
5cd460e fix(amazon/targetGroups): Handle empty healthCheckPath (#8727)
@caseyhebebrand caseyhebebrand mentioned this pull request Nov 12, 2020
Merged
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
@caseyhebebrand @mergify
chore(amazon): publish amazon@0.0.280
6f3be9a 
5cd460e fix(amazon/targetGroups): Handle empty healthCheckPath (#8727)
mergify bot pushed a commit that referenced this pull request Nov 12, 2020
@caseyhebebrand @mergify
chore(core): publish core@0.0.529
0429a97 
f2c6b4f fix(core/instance): Optional copyable sshLink to InstanceDetailsHeader (#8728)
5cd460e fix(amazon/targetGroups): Handle empty healthCheckPath (#8727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robzienert robzienert robzienert approved these changes

@christopherthielen christopherthielen christopherthielen approved these changes

@caseyhebebrand caseyhebebrand Awaiting requested review from caseyhebebrand

Assignees
No one assigned
Labels
ready to merge Reviewed and ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@vigneshm @christopherthielen @robzienert