feat(titus): Support SpEL for Run Job stage inputs #8809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Dec 17, 2020
vigneshm
added a commit
that referenced
this pull request
Jan 13, 2021
paragbhingre
pushed a commit
to paragbhingre/deck
that referenced
this pull request
Jan 21, 2021
82dca5f feat(titus): Support SpEL for Run Job stage inputs (spinnaker#8809) f5e81b8 feat(titus): Support SpEL for Resources number inputs (spinnaker#8808)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to check the Titus Run Job stage when I originally did #8808
Apparently it is not using
ServerGroupResourcesso it didn't come along for the ride.I originally wanted to move this whole stage over to
Formik, so that it could share that component with the Titus deploy dialog, but there are other things I want to spend time thinking through for that so would prefer to migrate that separate from bringing SpEL support to the run job stage.