Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/ManualJudgment): Enhanced ManualJudgment #8818

Merged
merged 22 commits into from May 14, 2021

Conversation

siddhu-opsmx
Copy link
Collaborator

@siddhu-opsmx siddhu-opsmx commented Dec 30, 2020

Goals and Non-Goals

Add a filter for filtering pipelines waiting on manual judgment. Checking this filter will automatically select the running stage filter and disable it(since all manual judgment pipelines are running). On deselecting the manual judgment filter the running filter will be enabled but still selected.

There will be a visual indication on all the stages that are waiting on manual judgment and clicking on the stage will take you to the root pipeline waiting on manual judgment.

Design

  1. Enhanced ExecutionMarker.tsx to
    -> If the leaf node of a pipeline execution waiting for judgment exist then reusing the UiRef component for redirection
    to leaf node waiting for manual judgment.
    -> If the stage durations setting is disabled, show a waiting icon.

  2. Enhanced executionMarker.less to
    -> Added a visual indicator to the stages waiting on manual judgment.

@siddhu-opsmx
Copy link
Collaborator Author

@caseyhebebrand @vigneshm @christopherthielen Could you please review the code.

Copy link
Contributor

@caseyhebebrand caseyhebebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some inline comments, but a couple more general observations that would be helpful:

  • Defining a more explicit type for manualJudgment. Using any is too vague, especially for an entity that has so many helper operations
  • Some of the helper functions are pretty complex (crossAppDataFetch, nestedManualJudgment). I would encourage you to either add supplementary comments, break these into smaller functions, or see if you can reduce any repeated logic that exists between components.

Copy link
Contributor

@caseyhebebrand caseyhebebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to all the feedback!

@caseyhebebrand caseyhebebrand added the ready to rebase Reviewed and ready to rebase and merge label May 14, 2021
@caseyhebebrand caseyhebebrand merged commit 91e864c into spinnaker:master May 14, 2021
christopherthielen added a commit that referenced this pull request May 14, 2021
834af1e fix(md): check if should use the new ui (#9179)
91e864c feat(core/ManualJudgment): Enhanced ManualJudgment (#8818)
4940c48 fix(core): classnames package cleanup (#9173)
mergify bot pushed a commit that referenced this pull request May 14, 2021
834af1e fix(md): check if should use the new ui (#9179)
91e864c feat(core/ManualJudgment): Enhanced ManualJudgment (#8818)
4940c48 fix(core): classnames package cleanup (#9173)
@siddhu-opsmx siddhu-opsmx deleted the PR/manualJudgementEnhancement branch May 2, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to rebase Reviewed and ready to rebase and merge target-release/1.27
Projects
None yet
5 participants