New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/ProjectHeader): Make component overridable #8997
Merged
mergify
merged 5 commits into
spinnaker:master
from
bbrina:feat-override-project-header
Mar 23, 2021
Merged
feat(core/ProjectHeader): Make component overridable #8997
mergify
merged 5 commits into
spinnaker:master
from
bbrina:feat-override-project-header
Mar 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogonthehorizon
approved these changes
Mar 23, 2021
christopherthielen
approved these changes
Mar 23, 2021
christopherthielen
added
ready to merge
Reviewed and ready for merge
and removed
ready to merge
Reviewed and ready for merge
labels
Mar 23, 2021
anotherchrisberry
added a commit
that referenced
this pull request
Mar 23, 2021
2ebdb9b fix(pr): added a warning 8bd72b5 fix(pr): only register MD plugin if necessary c3139a7 refactor(pr): Updated render functions type and moved files around 301b002 feat(pr): add a separate function for rendering the description 6236351 fix(pr): missing docs 0a7f528 fix(pr): renaming 931c885 fix(pr): simplified types 84185ef fix(pr): missing optional 421a7f8 feat(md): new constraint plugin registry 0d83fb3 refactor(md): move constraintRegistry to another folder c6fd509 feat(core/pipeline): Validate that submitted pipeline is not stale (hasn't been changed by another user) (#9027) 0061587 fix(core/projects): Recent projects: only save the link to project dashboard (#9024) ba9835a feat(core/ExecutionGroup): make component overridable (#8999) 7e0bfd2 feat(core/Execution): make component overridable (#9000) b4d3da3 feat(core/ApplicationDataSourceRegistry): Remove data source based on key (#9003) a1aae99 feat(core/ProjectHeader): Make component overridable (#8997) 22c76b1 fix(core/presentation): Add deps to useCallback (#9021) 76754d2 fix(pipeline): Collapse parameters in ancestry (#9017) 8fb7b70 fix(pipeline): Move configure into execution (#9013)
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2021
2ebdb9b fix(pr): added a warning 8bd72b5 fix(pr): only register MD plugin if necessary c3139a7 refactor(pr): Updated render functions type and moved files around 301b002 feat(pr): add a separate function for rendering the description 6236351 fix(pr): missing docs 0a7f528 fix(pr): renaming 931c885 fix(pr): simplified types 84185ef fix(pr): missing optional 421a7f8 feat(md): new constraint plugin registry 0d83fb3 refactor(md): move constraintRegistry to another folder c6fd509 feat(core/pipeline): Validate that submitted pipeline is not stale (hasn't been changed by another user) (#9027) 0061587 fix(core/projects): Recent projects: only save the link to project dashboard (#9024) ba9835a feat(core/ExecutionGroup): make component overridable (#8999) 7e0bfd2 feat(core/Execution): make component overridable (#9000) b4d3da3 feat(core/ApplicationDataSourceRegistry): Remove data source based on key (#9003) a1aae99 feat(core/ProjectHeader): Make component overridable (#8997) 22c76b1 fix(core/presentation): Add deps to useCallback (#9021) 76754d2 fix(pipeline): Collapse parameters in ancestry (#9017) 8fb7b70 fix(pipeline): Move configure into execution (#9013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds code to make ProjectHeader component overridable