fix(core/modal): Make SubmitButton compatible with flex display #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshm
approved these changes
Jun 22, 2021
ranihorev
pushed a commit
that referenced
this pull request
Jun 25, 2021
1406c2f fix(core/help): Do not render conditionally for angular compatibility (#9373) d83f600 refactor(core): Reactify ViewChangesLink, ChangesModal, CommitHistory and JarDiff (#9359) 57ce3d3 feat(md): backend messages (#9366) 4469f0b feat(md): added links to resources (#9356) 8180812 fix(core/modal): Make SubmitButton compatible with flex display (#9368) c18b86a fix(md): css fix for no artifacts (#9370)
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
1406c2f fix(core/help): Do not render conditionally for angular compatibility (#9373) d83f600 refactor(core): Reactify ViewChangesLink, ChangesModal, CommitHistory and JarDiff (#9359) 57ce3d3 feat(md): backend messages (#9366) 4469f0b feat(md): added links to resources (#9356) 8180812 fix(core/modal): Make SubmitButton compatible with flex display (#9368) c18b86a fix(md): css fix for no artifacts (#9370)
|
Thank you, thank you, thank you! :) cc: @luispollo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this issue:
Adding
flex-container-hdirectly to thebuttonreally messes up all the angular modal footers. Instead I made a new container within the button that allows the button to be flex and the footer to be compatible with the rest of the modal.