Migrate some amazon code to typescript #9742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
force-pushed
the
amazon-typescript-migration
branch
4 times, most recently
from
88a0100
to
835a0c6
Compare
christopherthielen
requested review from
vigneshm,
caseyhebebrand and
alanmquach
christopherthielen
force-pushed
the
amazon-typescript-migration
branch
from
835a0c6
to
cf57730
Compare
mattgogerly
reviewed
Oct 14, 2021
| @@ -39,7 +39,7 @@ export interface ILicenseConfig { | |||
| export interface IMetadataOptions { | |||
| httpEndpoint?: 'disabled' | 'enabled'; | |||
| httpPutResponseHopLimit?: number; | |||
| httpsTokens?: 'required' | 'optional'; | |||
| httpTokens?: 'required' | 'optional'; | |||
There was a problem hiding this comment.
Not familiar at all with the AWS code base, but purely from an interest standpoint what's the reasoning for this?
There was a problem hiding this comment.
this interface was incorrectly written as httpsTokens but the backend expects httpTokens. The code that exercised this was Javascript, not Typescript so the incorrect interface definition wasn't caught earlier.
mattgogerly
reviewed
Oct 14, 2021
christopherthielen
force-pushed
the
amazon-typescript-migration
branch
from
cf57730
to
4ab0714
Compare
christopherthielen
force-pushed
the
amazon-typescript-migration
branch
2 times, most recently
from
8e13436
to
b137ab5
Compare
christopherthielen
added
ready to rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change is
AwsInstanceTypeServiceandAwsServerGroupCommandBuilderGithub isn't really tracking all the renames so the diff looks awful. Review if you can/want. I hope I didn't break anything.