Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): run yarn modules before yarn build #9826

Merged
merged 2 commits into from
Mar 22, 2022
Merged

chore(build): run yarn modules before yarn build #9826

merged 2 commits into from
Mar 22, 2022

Conversation

mattgogerly
Copy link
Member

yarn build needs dependencies to have been built first via yarn modules to succeed. Adds a Gradle task to run yarn modules before yarn build.

Also fixing file paths for the version file because using new File() in Gradle causes all sorts of problems.

@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2022

update

✅ Branch has been successfully updated

@kskewes-sf
Copy link
Contributor 

$ ./gradlew buildDeb

$ dpkg-deb --info ./build/distributions/spinnaker-deck_0_all.deb
 new Debian package, version 2.0.
 size 14171004 bytes: control archive=2462 bytes.
     201 bytes,    10 lines      control              
    5549 bytes,    73 lines      md5sums              
 Package: spinnaker-deck
 Source: spinnaker-deck
 Version: 0
 Section: java
 Priority: optional
 Architecture: all
 Depends: apache2 (>= 2.4.7)
 Installed-Size: 47307
 Maintainer: ?
 Description: spinnaker-deck

@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Mar 22, 2022
@mergify mergify bot merged commit 45cf778 into spinnaker:master Mar 22, 2022
@mattgogerly mattgogerly deleted the fix-build branch March 22, 2022 18:47
@mattgogerly
Copy link
Member Author

@Mergifyio backport release-1.27.x

mergify bot pushed a commit that referenced this pull request Mar 22, 2022
@mattgogerly
chore(build): run yarn modules before yarn build (#9826)
9a2b252 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 45cf778)
@mergify mergify bot mentioned this pull request Mar 22, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2022

backport release-1.27.x

✅ Backports have been created

dbyron-sf pushed a commit that referenced this pull request Mar 22, 2022
@mergify @mattgogerly
chore(build): run yarn modules before yarn build (#9826) (#9827)
0c1ba16 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 45cf778)

Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

@kskewes-sf kskewes-sf kskewes-sf approved these changes

Assignees
No one assigned
Labels
ready to merge Reviewed and ready for merge target-release/1.28
Projects
None yet
Milestone
No milestone
4 participants
@mattgogerly @dbyron-sf @kskewes-sf @spinnakerbot