New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(timeout): Added feature flag for rollback timeout ui input. #9937
Merged
mergify
merged 3 commits into
spinnaker:master
from
armory-io:rollback_timeout_feature_flag
Feb 2, 2023
Merged
fix(timeout): Added feature flag for rollback timeout ui input. #9937
mergify
merged 3 commits into
spinnaker:master
from
armory-io:rollback_timeout_feature_flag
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport release-2.28.x |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@ovidiupopa07 or @dogonthehorizon please backport this pr to 1.28.x |
@mergify backport release-1.27.x release-1.28.x release-1.29.x |
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # app/scripts/modules/app/src/settings.js # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
✅ Backports have been created
|
dogonthehorizon
pushed a commit
that referenced
this pull request
Feb 3, 2023
…port #9937) (#9941) * fix(timeout): Added feature flag for rollback timeout ui input. (#9937) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html * fix(timeout): Added feature flag for rollback timeout ui input. (#9944) --------- Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
dogonthehorizon
pushed a commit
that referenced
this pull request
Feb 3, 2023
…port #9937) (#9940) * fix(timeout): Added feature flag for rollback timeout ui input. (#9937) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html * fix(timeout): Added feature flag for rollback timeout ui input. (#9942) --------- Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
dogonthehorizon
pushed a commit
that referenced
this pull request
Feb 3, 2023
…port #9937) (#9939) * fix(timeout): Added feature flag for rollback timeout ui input. (#9937) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # app/scripts/modules/app/src/settings.js # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html * fix(timeout): Added feature flag for rollback timeout ui input. (#9943) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. --------- Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
DanielaS12
added a commit
to DanielaS12/spinnaker.io
that referenced
this pull request
Feb 6, 2023
Added doc for: spinnaker/orca#4383 and spinnaker/deck#9937
aimeeu
added a commit
to spinnaker/spinnaker.io
that referenced
this pull request
Feb 6, 2023
* Dynamic rollback timeout instructions. Added doc for: spinnaker/orca#4383 and spinnaker/deck#9937 * copy edits --------- Co-authored-by: aimee <aimeeu.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merged
Merged automatically by a bot
ready to merge
Reviewed and ready for merge
target-release/1.30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature flag to rollback timeout value input.