Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeout): Added feature flag for rollback timeout ui input. #9937

Merged
merged 3 commits into from Feb 2, 2023

Conversation

DanielaS12
Copy link
Contributor

Added feature flag to rollback timeout value input.

Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Feb 2, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 2, 2023
@mergify mergify bot merged commit e239be3 into spinnaker:master Feb 2, 2023
@DanielaS12
Copy link
Contributor Author

@Mergifyio backport release-2.28.x

@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

backport release-2.28.x

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@DanielaS12
Copy link
Contributor Author

@ovidiupopa07 or @dogonthehorizon please backport this pr to 1.28.x

@ovidiupopa07
Copy link
Contributor

@mergify backport release-1.27.x release-1.28.x release-1.29.x

mergify bot pushed a commit that referenced this pull request Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	app/scripts/modules/app/src/settings.js
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
mergify bot pushed a commit that referenced this pull request Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
mergify bot pushed a commit that referenced this pull request Feb 2, 2023
* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

backport release-1.27.x release-1.28.x release-1.29.x

✅ Backports have been created

dogonthehorizon pushed a commit that referenced this pull request Feb 3, 2023
…port #9937) (#9941)

* fix(timeout): Added feature flag for rollback timeout ui input. (#9937)

* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html

* fix(timeout): Added feature flag for rollback timeout ui input. (#9944)

---------

Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
dogonthehorizon pushed a commit that referenced this pull request Feb 3, 2023
…port #9937) (#9940)

* fix(timeout): Added feature flag for rollback timeout ui input. (#9937)

* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html

* fix(timeout): Added feature flag for rollback timeout ui input. (#9942)

---------

Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
dogonthehorizon pushed a commit that referenced this pull request Feb 3, 2023
…port #9937) (#9939)

* fix(timeout): Added feature flag for rollback timeout ui input. (#9937)

* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

(cherry picked from commit e239be3)

# Conflicts:
#	app/scripts/modules/app/src/settings.js
#	packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html

* fix(timeout): Added feature flag for rollback timeout ui input. (#9943)

* fix(timeout): Added feature flag for rollback timeout ui input.

* fix(timeout): Added feature flag for rollback timeout ui input.

---------

Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com>
DanielaS12 added a commit to DanielaS12/spinnaker.io that referenced this pull request Feb 6, 2023
aimeeu added a commit to spinnaker/spinnaker.io that referenced this pull request Feb 6, 2023
* Dynamic rollback timeout instructions.

Added doc for:
spinnaker/orca#4383 and spinnaker/deck#9937

* copy edits

---------

Co-authored-by: aimee <aimeeu.opensource@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.30
Projects
None yet
3 participants