Skip to content

Commit

Permalink
fix(notifications): Need to maintain enum order (#589)
Browse files Browse the repository at this point in the history
* fix(notifications):  Need to maintain enum order

HIPCHAT was removed from the Enum here, but this enum is duplicated in
other microservices (for example, in Orca,
orca-echo/src/main/groovy/com/netflix/spinnaker/orca/echo/EchoService.groovy
has a copy of the list)

This is a quick fix to repair the numbering scheme.  This should
probably be fully refactored so the enum is either a) specifying actual
values for each type so they maintain consistency going forward, b)
unify in kork somehow, or c) both.

* Keep old enum name, update comment, per request.
  • Loading branch information
dotdotdotpaul authored and robzienert committed Jun 28, 2019
1 parent 98a92a0 commit 6f6b500
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class Notification {
EMAIL,
GITHUB_STATUS,
GOOGLECHAT,
HIPCHAT, // DEPRECATED/UNUSED; support was removed in commit d175913ab
JIRA,
PAGER_DUTY,
PUBSUB,
Expand Down

0 comments on commit 6f6b500

Please sign in to comment.