Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Need to maintain enum order #589

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

dotdotdotpaul
Copy link
Contributor

HIPCHAT was removed from the Enum here, but this enum is duplicated in
other microservices (for example, in Orca,
orca-echo/src/main/groovy/com/netflix/spinnaker/orca/echo/EchoService.groovy
has a copy of the list)

This is a quick fix to repair the numbering scheme. This should
probably be fully refactored so the enum is either a) specifying actual
values for each type so they maintain consistency going forward, b)
unify in kork somehow, or c) both.

HIPCHAT was removed from the Enum here, but this enum is duplicated in
other microservices (for example, in Orca,
orca-echo/src/main/groovy/com/netflix/spinnaker/orca/echo/EchoService.groovy
has a copy of the list)

This is a quick fix to repair the numbering scheme.  This should
probably be fully refactored so the enum is either a) specifying actual
values for each type so they maintain consistency going forward, b)
unify in kork somehow, or c) both.
@robzienert
Copy link
Member

Let's just change it back to HIPCHAT and keep the comment something along the lines that it's unused because it's been deprecated. UNUSED may be confusing if not looking directly at the enum.

Thanks for fixing this!

@robzienert robzienert merged commit 6f6b500 into spinnaker:master Jun 28, 2019
@dotdotdotpaul dotdotdotpaul deleted the fix-notification-enum branch June 28, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants