fix(logging): Fix log lines in quartzdiscoveryactivator (#1052)

spinnaker · Nov 3, 2020 · b7db299 · b7db299
1 parent e614e5c
commit b7db299
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/...roovy/com/netflix/spinnaker/echo/scheduler/actions/pipeline/QuartzDiscoveryActivator.java b/...roovy/com/netflix/spinnaker/echo/scheduler/actions/pipeline/QuartzDiscoveryActivator.java
@@ -15,6 +15,7 @@
  */
 package com.netflix.spinnaker.echo.scheduler.actions.pipeline;
 
+import com.netflix.spinnaker.kork.discovery.DiscoveryStatusChangeEvent;
 import com.netflix.spinnaker.kork.discovery.InstanceStatus;
 import com.netflix.spinnaker.kork.discovery.RemoteStatusChangedEvent;
 import lombok.extern.slf4j.Slf4j;
@@ -32,19 +33,21 @@ public QuartzDiscoveryActivator(Scheduler scheduler) {
 
   @Override
   public void onApplicationEvent(RemoteStatusChangedEvent event) {
-    if (event.getSource().getStatus() == InstanceStatus.UP) {
-      log.info("Instance is ${e.status}... resuming quartz scheduler");
+    DiscoveryStatusChangeEvent e = event.getSource();
+
+    if (e.getStatus() == InstanceStatus.UP) {
+      log.info("Instance is {}... resuming quartz scheduler", e.getStatus());
       try {
         scheduler.start();
-      } catch (SchedulerException e) {
-        log.warn("Failed to resume quartz scheduler", e);
+      } catch (SchedulerException ex) {
+        log.warn("Failed to resume quartz scheduler", ex);
       }
     } else if (event.getSource().getPreviousStatus() == InstanceStatus.UP) {
-      log.info("Instance is ${e.status}... placing quartz into standby");
+      log.info("Instance is {}... placing quartz into standby", e.getStatus());
       try {
         scheduler.standby();
-      } catch (SchedulerException e) {
-        log.warn("Failed to place quartz scheduler into standby", e);
+      } catch (SchedulerException ex) {
+        log.warn("Failed to place quartz scheduler into standby", ex);
       }
     }
   }