chore(logs): allow anonymous call to front50 to get pipelines #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron0
force-pushed
the
clean_up_warnings
branch
from
a5a50bd
to
4f5c537
Compare
dreynaud
reviewed
Mar 18, 2021
echo-telemetry/echo-telemetry.gradle
Outdated
| @@ -22,6 +22,7 @@ dependencies { | |||
| implementation project(':echo-core') | |||
| implementation "com.netflix.spinnaker.kork:kork-jedis" | |||
| implementation 'com.google.protobuf:protobuf-java-util' | |||
| implementation "com.netflix.spinnaker.kork:kork-exceptions" | |||
There was a problem hiding this comment.
This is where com.netflix.spinnaker.security.AuthenticatedRequest lives...The code doesn't compile without it. https://github.com/spinnaker/kork/blob/master/kork-security/src/main/java/com/netflix/spinnaker/security/AuthenticatedRequest.java
There was a problem hiding this comment.
or maybe...I'm getting this wrong and have copy-pasted from other similar changes...gimme a minute.
There was a problem hiding this comment.
Sorry, it does in fact compile with nothing additional here. I think it's correct to add
implementation "com.netflix.spinnaker.kork:kork-security"
instead of kork-exceptions though, since kork-security is actually where AuthenticatedRequest lives....like this: 8021a56
There was a problem hiding this comment.
Thanks for catching this btw!
There was a problem hiding this comment.
thanks, looking good now 👍
added 2 commits
March 18, 2021 15:01
to clean up warnings like: 2021-03-17 22:51:04.801 WARN 1 --- [oScheduler-1063] c.n.s.okhttp.OkHttp3MetricsInterceptor : Request GET:http://spin-front50.spinnaker-stage:8080/pipelines?restricted=false is missing [X-SPINNAKER-USER, X-SPINNAKER-ACCOUNTS] authentication headers and will be treated as anonymous. Request from: com.netflix.spinnaker.okhttp.MetricsInterceptor.doIntercept(MetricsInterceptor.java:98) at com.netflix.spinnaker.okhttp.OkHttp3MetricsInterceptor.intercept(OkHttp3MetricsInterceptor.java:36) at com.netflix.spinnaker.echo.telemetry.PipelineCountsDataProvider.retrievePipelines(PipelineCountsDataProvider.kt:48) at com.netflix.spinnaker.echo.telemetry.PipelineCountsDataProvider.access$retrievePipelines(PipelineCountsDataProvider.kt:30) at com.netflix.spinnaker.echo.telemetry.PipelineCountsDataProvider$appPipelinesSupplier$1.get(PipelineCountsDataProvider.kt:33) at com.netflix.spinnaker.echo.telemetry.PipelineCountsDataProvider$appPipelinesSupplier$1.get(PipelineCountsDataProvider.kt:30) at com.netflix.spinnaker.echo.telemetry.PipelineCountsDataProvider.populateData(PipelineCountsDataProvider.kt:38) at com.netflix.spinnaker.echo.telemetry.TelemetryEventListener.processEvent(TelemetryEventListener.java:94) at com.netflix.spinnaker.echo.events.EventPropagator.lambda$processEvent$0(EventPropagator.java:71) at com.netflix.spinnaker.security.AuthenticatedRequest.lambda$wrapCallableForPrincipal$0(AuthenticatedRequest.java:272) at com.netflix.spinnaker.echo.events.EventPropagator.lambda$processEvent$2(EventPropagator.java:78)
dbyron0
force-pushed
the
clean_up_warnings
branch
from
4f5c537
to
8021a56
Compare
dreynaud
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to clean up warnings like: