Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhooks): Handle Bitbucket Server PR events #1219

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

sergio-quintero
Copy link
Contributor

@sergio-quintero sergio-quintero commented Nov 23, 2022

  • Separate Bitbucket Server logic into its own class.
  • Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:

  • pr:opened
  • pr:from_ref_updated
  • pr:deleted
  • pr:declined

Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with 2 minor comments

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
…Replace emptyOrDefault with StringUtils.defaultIfEmpty
@dogonthehorizon dogonthehorizon added the ready to merge Approved and ready for merge label Nov 30, 2022
@mergify mergify bot added the auto merged label Nov 30, 2022
@mergify mergify bot merged commit a454509 into spinnaker:master Nov 30, 2022
@sergio-quintero sergio-quintero deleted the feat/add_bitbucketserver_events branch November 30, 2022 17:25
sergio-quintero added a commit to armory-io/echo that referenced this pull request Dec 6, 2022
Backporting spinnaker#1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
sergio-quintero added a commit to armory-io/echo that referenced this pull request Dec 6, 2022
Backporting spinnaker#1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
sergio-quintero added a commit to armory-io/echo that referenced this pull request Dec 6, 2022
Backporting spinnaker#1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
sergio-quintero added a commit to armory-io/echo that referenced this pull request Dec 6, 2022
Backporting spinnaker#1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
sergio-quintero added a commit to armory-io/echo that referenced this pull request Dec 6, 2022
Backporting spinnaker#1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
mergify bot pushed a commit that referenced this pull request Dec 6, 2022
Backporting #1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
mergify bot pushed a commit that referenced this pull request Dec 6, 2022
Backporting #1219 under a feature flag.

* Separate Bitbucket Server logic into its own class.
* Move Bitbucket Server Event classes into its own classes.

Bitbucket Server events:
* pr:opened
* pr:from_ref_updated
* pr:deleted
* pr:declined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants