-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhooks): Handle Bitbucket Server PR events #1219
Merged
mergify
merged 3 commits into
spinnaker:master
from
armory-io:feat/add_bitbucketserver_events
Nov 30, 2022
Merged
feat(webhooks): Handle Bitbucket Server PR events #1219
mergify
merged 3 commits into
spinnaker:master
from
armory-io:feat/add_bitbucketserver_events
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
763ae60
to
8e9bbcb
Compare
ovidiupopa07
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with 2 minor comments
...main/groovy/com/netflix/spinnaker/echo/scm/bitbucket/server/BitbucketServerEventHandler.java
Outdated
Show resolved
Hide resolved
...main/groovy/com/netflix/spinnaker/echo/scm/bitbucket/server/BitbucketServerEventHandler.java
Show resolved
Hide resolved
nemesisOsorio
suggested changes
Nov 23, 2022
echo-webhooks/src/main/groovy/com/netflix/spinnaker/echo/scm/BitbucketWebhookEventHandler.java
Outdated
Show resolved
Hide resolved
echo-webhooks/src/main/groovy/com/netflix/spinnaker/echo/scm/BitbucketWebhookEventHandler.java
Outdated
Show resolved
Hide resolved
...main/groovy/com/netflix/spinnaker/echo/scm/bitbucket/server/BitbucketServerEventHandler.java
Outdated
Show resolved
Hide resolved
nemesisOsorio
approved these changes
Nov 23, 2022
* Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
…o improve readability.
…Replace emptyOrDefault with StringUtils.defaultIfEmpty
6ee40d4
to
05740b2
Compare
dogonthehorizon
approved these changes
Nov 30, 2022
sergio-quintero
added a commit
to armory-io/echo
that referenced
this pull request
Dec 6, 2022
Backporting spinnaker#1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
sergio-quintero
added a commit
to armory-io/echo
that referenced
this pull request
Dec 6, 2022
Backporting spinnaker#1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
sergio-quintero
added a commit
to armory-io/echo
that referenced
this pull request
Dec 6, 2022
Backporting spinnaker#1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
sergio-quintero
added a commit
to armory-io/echo
that referenced
this pull request
Dec 6, 2022
Backporting spinnaker#1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
sergio-quintero
added a commit
to armory-io/echo
that referenced
this pull request
Dec 6, 2022
Backporting spinnaker#1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Backporting #1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Backporting #1219 under a feature flag. * Separate Bitbucket Server logic into its own class. * Move Bitbucket Server Event classes into its own classes. Bitbucket Server events: * pr:opened * pr:from_ref_updated * pr:deleted * pr:declined
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket Server events: