-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event): Add circuit breaker for events sending. #1233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
reviewed
Dec 9, 2022
echo-rest/src/main/java/com/netflix/spinnaker/echo/events/RestEventListener.java
Outdated
Show resolved
Hide resolved
ovidiupopa07
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasonmcintosh
approved these changes
Dec 12, 2022
dogonthehorizon
approved these changes
Dec 14, 2022
Has feature flag and is tested, backporting |
@Mergifyio backport release-1.29.x release-1.28.x release-1.27.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16)
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16)
This was referenced Dec 14, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16)
mergify bot
added a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Dec 14, 2022
* feat(event): Add circuit breaker for events sending. * refactor: Move send event without Circuit Breaker to the event service. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 28d0b16) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The event may have payload size up to 10 MB and even more, there are no strict limits. The number of events to be sent can be large. It depends on how frequently Spinnaker runs pipelines, and other internal jobs. As a result, if consumer API is unavailable or has high latency then Echo service is constantly restarting due to Out of Memory error.
How to use?
Add to
echo-local.yml
: