Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The circuit breaker feature for sending events to telemetry endpoint is hidden under a required feature flag property (backport #1241) #1246

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: The circuit breaker feature for sending events to telemetry endpoint is hidden under a required feature flag property (backport #1241) #1246

merged 1 commit into from
Jan 20, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 20, 2023

This is an automatic backport of pull request #1241 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ovidiupopa07 @mergify
fix: The circuit breaker feature for sending events to telemetry endp…
e4ab240 
…oint is hidden under a required feature flag property (#1241)

It should be optional - if no config is defined in the YAML file, it should disable the circuit breaker feature by default

(cherry picked from commit 7ae0247)
@mergify mergify bot mentioned this pull request Jan 20, 2023
Merged
@dogonthehorizon dogonthehorizon added the ready to merge Approved and ready for merge label Jan 20, 2023
@mergify mergify bot added the auto merged label Jan 20, 2023
@mergify mergify bot merged commit d764c8d into release-1.29.x Jan 20, 2023
@mergify mergify bot deleted the mergify/bp/release-1.29.x/pr-1241 branch January 20, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogonthehorizon dogonthehorizon dogonthehorizon approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.29
Projects
None yet
Milestone
No milestone
3 participants
@dogonthehorizon @spinnakerbot @ovidiupopa07